Round decimal and eventually use a Decimal library #32
Assignees
Comments
Merged
Tip
|
|
/start |
Tip
|
|
Two start messages but only one assigned. This isn't right @gentlementlegen Also it should assign and then post the start message. |
|
@Keyrxng rfc What I think happened is:
It should have just said "You are already assigned to this task" because it should have been the case. |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 75 |
| Review | Comment | 8 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Resolves #32```ts// Examples:console.log(custo… | 0content:
content:
p:
score: 0
elementCount: 1
pre:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 2
wordValue: 0
result: 0
| 0.7 | - |
Appreciate the heads-up! | 0.65content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 4
wordValue: 0.2
result: 0.65
| 0.1 | - |
Hi @gentlementlegen, I've added the unit tests! May I ask what t… | 2.44content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 19
wordValue: 0.2
result: 2.44
| 0.8 | - |
@gentlementlegen, I see you've been working with a testing deplo… | 8.38content:
content:
p:
score: 0
elementCount: 3
pre:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 81
wordValue: 0.2
result: 8.38
| 0.9 | - |
## QAPlease refer to this Github issue:https://github.com/Ub… | 3.11content:
content:
h2:
score: 1
elementCount: 1
p:
score: 0
elementCount: 2
result: 1
regex:
wordCount: 16
wordValue: 0.2
result: 2.11
| 0.2 | - |
Hey @gentlementlegen, I’ve thrown in a few more test cases. Also… | 3.7content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 31
wordValue: 0.2
result: 3.7
| 0.6 | - |
@gentlementlegen Yeah, that happens sometimes LOL, did a cleanup. | 1.29content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 9
wordValue: 0.2
result: 1.29
| 0.3 | - |
@gentlementlegen Is there anything else to complete before mergi… | 1.42content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 10
wordValue: 0.2
result: 1.42
| 0.2 | - |
[ 2.717 WXDAI ]
@0x4007
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 1 | 0.966 |
| Review | Comment | 4 | 1.751 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Two start messages but only one assigned. This isn't right @gent… | 1.38content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 22
wordValue: 0.1
result: 1.38
| 0.7 | 0.966 |
Bad approach use a number library so rounding is accurate. You'r… | 1content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 15
wordValue: 0.1
result: 1
| 0.9 | 0.9 |
Seems close | 0.18content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 2
wordValue: 0.1
result: 0.18
| 0.2 | 0.036 |
Probably should add more tests with two decimals and more decim… | 0.77content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 11
wordValue: 0.1
result: 0.77
| 0.7 | 0.539 |
Two seem appropriate like traditional currency. | 0.46content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0.6 | 0.276 |
[ 25.752 WXDAI ]
@gentlementlegen
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 9.06 |
| Issue | Comment | 1 | 7.71 |
| Review | Comment | 11 | 8.982 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
When using certain duration settings, the pricing doesn't round … | 3.02content:
content:
p:
score: 0
elementCount: 2
em:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 55
wordValue: 0.1
result: 3.02
| 1 | 9.06 |
@Keyrxng rfcWhat I think happened is:- no user was assigned… | 10.85content:
content:
p:
score: 0
elementCount: 7
ul:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 4
result: 3
regex:
wordCount: 75
wordValue: 0.2
result: 7.85
| 0.6 | 7.71 |
Please add the required tests, otherwise good to go with the PR. | 0.83content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 12
wordValue: 0.1
result: 0.83
| 0.7 | 0.581 |
It seems your last commit added a lot of files that should not b… | 1.33content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 21
wordValue: 0.1
result: 1.33
| 0.6 | 0.798 |
Maybe add a test with `0.73 hours` or things like that t… | 1.06content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 16
wordValue: 0.1
result: 1.06
| 0.8 | 0.848 |
I think you can use `as unknown as Context` to avoid dis… | 0.59content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 8
wordValue: 0.1
result: 0.59
| 0.9 | 0.531 |
Should be removed. | 0.25content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 3
wordValue: 0.1
result: 0.25
| 0.4 | 0.1 |
Should be removed. | 0.25content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 3
wordValue: 0.1
result: 0.25
| 0.4 | 0.1 |
Should be removed. | 0.25content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 3
wordValue: 0.1
result: 0.25
| 0.4 | 0.1 |
Could you add:- unit tests- a link to a QA test | 2.77content:
content:
p:
score: 0
elementCount: 3
ul:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 2
result: 2
regex:
wordCount: 11
wordValue: 0.1
result: 0.77
| 0.75 | 2.5775 |
@hhio618 Thank you. If you could try running it in your org with… | 2.83content:
content:
p:
score: 0
elementCount: 2
hr:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 51
wordValue: 0.1
result: 2.83
| 0.65 | 1.8395 |
@hhio618 This might help you get started: https://github.com/ubi… | 2.45content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 43
wordValue: 0.1
result: 2.45
| 0.5 | 1.225 |
No, just a second pair of eyes, when @0x4007 approves it will ge… | 0.94content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 14
wordValue: 0.1
result: 0.94
| 0.3 | 0.282 |
|
@gentlementlegen my link doesn't work |
|
@0x4007 This error seems familiar: https://github.com/ubiquity-os-marketplace/conversation-rewards/actions/runs/11165001249/job/31035657102#step:7:463 |
@whilefoo can you make a fix for this? |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 75 |
| Review | Comment | 8 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Resolves #32```ts// Examples:console.log(custo… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 2
wordValue: 0
result: 0
| 0.9 | 0 |
Appreciate the heads-up! | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 4
wordValue: 0
result: 0
| 0.2 | 0 |
Hi @gentlementlegen, I've added the unit tests! May I ask what t… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 19
wordValue: 0
result: 0
| 0.7 | 0 |
@gentlementlegen, I see you've been working with a testing deplo… | 0content:
content:
p:
score: 0
elementCount: 3
result: 0
regex:
wordCount: 81
wordValue: 0
result: 0
| 0.8 | 0 |
## QAPlease refer to this Github issue:https://github.com/Ub… | 1content:
content:
h2:
score: 1
elementCount: 1
p:
score: 0
elementCount: 2
result: 1
regex:
wordCount: 16
wordValue: 0
result: 0
| 0.5 | 0 |
Hey @gentlementlegen, I’ve thrown in a few more test cases. Also… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 31
wordValue: 0
result: 0
| 0.7 | 0 |
@gentlementlegen Yeah, that happens sometimes LOL, did a cleanup. | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 9
wordValue: 0
result: 0
| 0.1 | 0 |
@gentlementlegen Is there anything else to complete before mergi… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 10
wordValue: 0
result: 0
| 0.3 | 0 |
[ 3.224 WXDAI ]
@0x4007
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 3 | 1.465 |
| Review | Comment | 4 | 1.759 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Two start messages but only one assigned. This isn't right @gent… | 1.38content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 22
wordValue: 0.1
result: 1.38
| 0.8 | 1.104 |
@gentlementlegen my link doesn't work | 0.46content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0.4 | 0.184 |
@whilefoo can you make a fix for this? | 0.59content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 8
wordValue: 0.1
result: 0.59
| 0.3 | 0.177 |
Bad approach use a number library so rounding is accurate. You'r… | 1content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 15
wordValue: 0.1
result: 1
| 0.8 | 0.8 |
Seems close | 0.18content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 2
wordValue: 0.1
result: 0.18
| 0.2 | 0.036 |
Probably should add more tests with two decimals and more decim… | 0.77content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 11
wordValue: 0.1
result: 0.77
| 0.9 | 0.693 |
Two seem appropriate like traditional currency. | 0.46content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0.5 | 0.23 |
[ 22.192 WXDAI ]
@gentlementlegen
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 9.06 |
| Issue | Comment | 2 | 6.067 |
| Review | Comment | 11 | 7.065 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
When using certain duration settings, the pricing doesn't round … | 3.02content:
content:
p:
score: 0
elementCount: 2
em:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 55
wordValue: 0.1
result: 3.02
| 1 | 9.06 |
@Keyrxng rfcWhat I think happened is:- no user was assigned… | 5.92content:
content:
p:
score: 0
elementCount: 7
ul:
score: 0
elementCount: 1
li:
score: 0.5
elementCount: 4
result: 2
regex:
wordCount: 75
wordValue: 0.1
result: 3.92
| 0.8 | 5.136 |
@0x4007 This error seems familiar: https://github.com/ubiquity-o… | 1.33content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 21
wordValue: 0.1
result: 1.33
| 0.7 | 0.931 |
Please add the required tests, otherwise good to go with the PR. | 0.83content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 12
wordValue: 0.1
result: 0.83
| 0.7 | 0.581 |
It seems your last commit added a lot of files that should not b… | 1.33content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 21
wordValue: 0.1
result: 1.33
| 0.8 | 1.064 |
Maybe add a test with `0.73 hours` or things like that t… | 1.06content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 16
wordValue: 0.1
result: 1.06
| 0.6 | 0.636 |
I think you can use `as unknown as Context` to avoid dis… | 0.59content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 8
wordValue: 0.1
result: 0.59
| 0.9 | 0.531 |
Should be removed. | 0.25content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 3
wordValue: 0.1
result: 0.25
| 0.3 | 0.075 |
Should be removed. | 0.25content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 3
wordValue: 0.1
result: 0.25
| 0.3 | 0.075 |
Should be removed. | 0.25content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 3
wordValue: 0.1
result: 0.25
| 0.3 | 0.075 |
Could you add:- unit tests- a link to a QA test | 1.77content:
content:
p:
score: 0
elementCount: 3
ul:
score: 0
elementCount: 1
li:
score: 0.5
elementCount: 2
result: 1
regex:
wordCount: 11
wordValue: 0.1
result: 0.77
| 0.7 | 1.539 |
@hhio618 Thank you. If you could try running it in your org with… | 2.83content:
content:
p:
score: 0
elementCount: 2
hr:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 51
wordValue: 0.1
result: 2.83
| 0.5 | 1.415 |
@hhio618 This might help you get started: https://github.com/ubi… | 2.45content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 43
wordValue: 0.1
result: 2.45
| 0.4 | 0.98 |
No, just a second pair of eyes, when @0x4007 approves it will ge… | 0.94content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 14
wordValue: 0.1
result: 0.94
| 0.1 | 0.094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using certain duration settings, the pricing doesn't round up and ends with a lot of decimals. In this case the number should be properly calculated and eventually truncated if needed. This happens for example when setting a time like
Time: <1 Minute.Originally posted by @gentlementlegen in ubiquibot/sandbox#23 (comment)
The text was updated successfully, but these errors were encountered: