Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow Start to Evaluation #138

Closed
0x4007 opened this issue Oct 3, 2024 · 6 comments
Closed

Slow Start to Evaluation #138

0x4007 opened this issue Oct 3, 2024 · 6 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Oct 3, 2024

We should fix this up and do an instant response when the issue is closed as complete. Its always a bit nerve wracking that its broken again because it takes like 20 seconds to post.

Easy answer is to just do a CURL post with the comment when starting the operation.

+ Evaluating results. Please wait...

Originally posted by @ubiquity-os[bot] in ubiquity-os-marketplace/daemon-pricing#32 (comment)

@gentlementlegen
Copy link
Member

Wouldn't this be fixed buy the way you found to quickly start Actions? Because the start message is at the top of the action before any clone or install actually happens so not sure if it can be made faster.

@0x4007
Copy link
Member Author

0x4007 commented Oct 5, 2024

Wow I see that now. I am not optimistic about going much faster compared to what you already did. I don't understand the length of time for the delay if the comment says it posted within a second according to the GitHub actions logs.

Perhaps with caching of some sort which is inherited with my implementation from my research but I'm not sure of the nuances because I'm borrowing that code

@gentlementlegen
Copy link
Member

Sometimes the runners are slow to pick up the task and start, if you add the delay for the comment to be posted + the UI to poll the changes I guess it can add up to ~5 seconds. I believe without using a Worker or any sort of backend that would instantly react to events, we are dependent on this delay.

@0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
@0x4007
Copy link
Member Author

0x4007 commented Oct 8, 2024

The only thing I can think of is caching. There is a slim chance that this is the solution but I am not very confident.

@gentlementlegen
Copy link
Member

Even with caching the runner can take time to be picked up for start. From my experiments with ncc the running is instant but the runner pick up still varies from 1 second to 5 minutes, which I don't think can be controlled. Let's see once we get the runs up.

@0x4007
Copy link
Member Author

0x4007 commented Oct 8, 2024

the runner pick up still varies from 1 second to 5 minutes, which I don't think can be controlled.

Yes I agree. The only thing we could hope for is to request a run when GitHub's infrastructure isn't so busy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants