Fix test for absent return values in thrift scheme #221
Conversation
thriftrw now raises TypeError if return value is absent for non-void methods.
|
lgtm thx for thefix |
| # response. thriftrw will fail with a TypeError on invalid values. For | ||
| # thrift, we'll check manually and raise ValueExpectedError. | ||
| if use_thriftrw_client: | ||
| exc = TypeError |
There was a problem hiding this comment.
Should this be caught and re-raised as ValueExpectedError for consistency?
There was a problem hiding this comment.
TypeError can also be raised if required arguments in a struct were absent, or on type mismatch. There's no error specific to "return value was absent" raised by thriftrw yet. I can fix that in the next version along with the unexpected exceptions support. Created thriftrw/thriftrw-python#49.
Meanwhile this fix should suffice because this is a very specific corner case that will happen only if the server is using Apache Thrift, the client is using thriftrw, and the server forgets to return a value (which would normally be caught by their tests/manual checks). And when it does occur, there's no good way for the client to handle it except blow up.
Fix test for absent return values in thrift scheme
thriftrw now raises TypeError if return value is absent for non-void methods.
@breerly @blampe @junchaoWu