Update LeakCanary to 2.10 #581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pyricau
commented
May 11, 2023
| @@ -141,7 +141,7 @@ protected constructor( | |||
| public open fun detachChild(childRouter: Router<*>) { | |||
| val isChildRemoved = children.remove(childRouter) | |||
| val interactor = childRouter.interactor | |||
| ribRefWatcher.watchDeletedObject(interactor) | |||
| ribRefWatcher.watchDeletedObject(interactor, "detached child router ${childRouter.javaClass.name}") | |||
There was a problem hiding this comment.
I made up a description. You might want something different. But it's nice to be able to provide context on what's causing this to be defined as something to be GCed.
tyvsmith
reviewed
May 12, 2023
| @@ -31,24 +29,17 @@ public class SampleApplication extends Application implements HasActivityDelegat | |||
| public void onCreate() { | |||
| activityDelegate = new SampleActivityDelegate(); | |||
| super.onCreate(); | |||
| if (!LeakCanary.isInAnalyzerProcess(this)) { | |||
There was a problem hiding this comment.
Was the separate process deprecated?
There was a problem hiding this comment.
It's optional now. Most apps shouldn't need it as LeakCanary uses a lot less memory, and this complicates the setup.
| public open fun watchDeletedObject(objectToWatch: Any?) { | ||
| public open fun watchDeletedObject( | ||
| objectToWatch: Any?, | ||
| description: String |
There was a problem hiding this comment.
Should be an optional param to avoid being a breaking API change for consumers
There was a problem hiding this comment.
Done by adding a deprecated overload without the param (that way it signifies clearly that the call should be updated)
pyricau
commented
May 12, 2023
| objectToWatch: Any?, | ||
| ) { | ||
| watchDeletedObject(objectToWatch, "missing description") | ||
| } |
There was a problem hiding this comment.
let me know if this works for you.
Also added the now required "description" parameter when watching instances. Fixes uber#580
Also, a couple of minor fixes: - A small warning on `RibActivity` against importing `android.R`. - Replaces deprecated `String.toLowerCase()` and `String.capitalize()` with the equivalent `String.lowercase()` and `String.replaceFirstChar(Char::titlecase)`.
This allows for a more repeatable, predictable build between different local configurations.
…_binder Deprecate old worker
- Define a dispatchers to be used on the now deprecated WorkerBinder/Worker within RibCoroutineConfig
uber#598 Fixing previous broken link https://eng.uber.com/new-rider-app with https://www.uber.com/blog/new-rider-app-architecture/
Allow overriding default CoroutineDispatcher for WorkerBinder calls
Update README.md
…RIBs into add_rib_monitoring
…tion Deprecate WorkerUnbinder
Expose ribActionEvents stream
…=all` Docs state that: > If you used the @JvmDefault annotation before, you can safely remove it and use one of the new modes. If you already used -Xjvm-default=enable, which generated only the default method implementations, you can now replace it with -Xjvm-default=all.
`List` is not really needed and we restrict the API unnecessarily: all we need is an `Iterable`. For keeping binary compatibility, we also keep the overloads taking in a `List`.
* Set view tree owners in RibActivity#onCreate * Cleanup duplicate setting of view tree owners * Add more assertions
…ibCoroutineWorker.kt Co-authored-by: Patrick Steiger <[email protected]>
Add RibCoroutineWorker.bind that receives multiple workers
…cher_to_default Change default CoroutineContext from empty to default for the RibCoroutineWorker<>Worker conversion
…iver.
`RibCoroutineWorker` is already a functional interface; the purpose of this builder is to allow consumers
to create a `RibCoroutineWorker` with `CoroutineScope` in receiver position. E.g.
- Functional interface:
```
RibCoroutineWorker { scope ->
scope.launch { ... }
}
```
- This factory method:
```
RibCoroutineWorker {
launch { ... }
}
```
Update coroutines 1.7.3
Also added the now required "description" parameter when watching instances. Fixes uber#580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added the now required "description" parameter when watching instances.
Before
After