-
Notifications
You must be signed in to change notification settings - Fork 208
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This brings back #233. Per #235 (review), the issues we need to resolve are, 1. `dig.As` seems to indicate that it's a total override of the provided type. The way it currently works is it appends other interfaces on top of whatever the constructor already returns 2. semantics of `dig.Provide(func New() (Foo, io.Reader, error), dig.As(new(io.Writer)`. It currently fails due to inability to case reader to writer, but we'd want some extra validation here. Perhaps `dig.As` is only supported for a single type, error tuple? Closes #197
- Loading branch information
1 parent
4fb70ce
commit 287b330
Showing
11 changed files
with
439 additions
and
55 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.