This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
FOLIO-3876: Breaking changes react v18 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zburke
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Code changes LGTM. Please add a note about this breaking change to the CHANGELOG.
NB: @testing-library/react-hooks has been folded directly into @testing-library/react as of v14. You have to update the import path for renderHook, but no other change is necessary, and then you can remove this extraneous dep.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per FOLIO-3876, fixing changes that were not addressed in initial upgrade to react v18.
Updating dependancies and test infrastructure.