This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

fix bug: issue #148 #149

Merged

GoZaddy merged 2 commits into master from faruq-new

Sep 14, 2023

GoZaddy commented Sep 13, 2023

No description provided.


          fix bug: issue #148

01c4345

GoZaddy requested review from ncovercash and nhanaa

September 13, 2023 22:59

GoZaddy self-assigned this

ncovercash approved these changes

View reviewed changes

Member

ncovercash left a comment

Nice find!

nhanaa commented Sep 14, 2023

@ncovercash The github action somehow fails but I'm not sure what the problem is. Is this concerning?

Member

ncovercash commented Sep 14, 2023

@Nhanna I can't see it on my phone, but I'm guessing the unit test for this is failing (since it probably passed in the previous (incorrect) property). I'd go check and update the corresponding unit test

Author

GoZaddy commented Sep 14, 2023

@Nhanna I can't see it on my phone, but I'm guessing the unit test for this is failing (since it probably passed in the previous (incorrect) property). I'd go check and update the corresponding unit test

Oh yeah, my bad. I'll go update that


          fix bug: issue #148

a050684

ncovercash approved these changes

View reviewed changes

Member

ncovercash left a comment

lgtm, assuming this fixes test issue

sonarqubecloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

nhanaa approved these changes

View reviewed changes

GoZaddy merged commit f7f07db into master

3 checks passed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet