-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hooks, support React 18, drop React < 16 #196
base: default
Are you sure you want to change the base?
Conversation
When do we expect to merge this? And why is it necessary to drop React <= 16 |
No real timeline on merging this, as it's not really that important for end users anyways. The feature set is the same as the class component version from 0.x. I want to align this release with my other embed modules (especially |
Any updates on when this or the other PRs will be merged? |
Not currently. are you looking for a particular improvement from this PR? |
Having a version number that is 1.0 makes the library an easier sell for usage in a project. |
I'll aim to finish, test, and release this by the time React 19 comes out. |
33e47ed
to
85a2673
Compare
Similar to u-wave/react-youtube#117.
This will be version 1.0 of the library.
It uses hooks internally instead of a class. The published code targets modern browsers but you can still transpile it if you need to.
There should be no API changes.