Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(loki): refinement" #2913

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

jazzlyn
Copy link
Collaborator

@jazzlyn jazzlyn commented Apr 30, 2024

Reverts #2911

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tyriis-automation
Copy link
Contributor

--- kubernetes/talos-flux/apps/observability/loki/app Kustomization: flux-system/apps-loki HelmRelease: observability/loki

+++ kubernetes/talos-flux/apps/observability/loki/app Kustomization: flux-system/apps-loki HelmRelease: observability/loki

@@ -51,13 +51,12 @@

       auth_enabled: false
       compactor:
         delete_request_store: s3
         retention_delete_delay: 2h
         retention_delete_worker_count: 150
         retention_enabled: true
-        working_directory: /var/loki/compactor/retention
       frontend:
         max_outstanding_per_tenant: 4096
       ingester:
         chunk_encoding: snappy
       limits_config:
         ingestion_burst_size_mb: 128
@@ -108,14 +107,12 @@

         annotations:
           kustomize.toolkit.fluxcd.io/substitute: disabled
         labels:
           grafana_dashboard: 'true'
       serviceMonitor:
         enabled: true
-        metricsInstance:
-          enabled: false
     read:
       extraVolumes:
       - configMap:
           name: loki-alerting-rules
         name: loki-rules
       persistence:

@tyriis-automation
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.3s
✅ YAML prettier 1 0 0.67s
✅ YAML yamllint 1 0 0.33s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@jazzlyn jazzlyn merged commit 3d28255 into main Apr 30, 2024
15 checks passed
@jazzlyn jazzlyn deleted the revert-2911-fix/loki-refinement branch April 30, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant