-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node-feature-discovery): update helm-release to v0.15.0 #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyriis-automation
bot
added
renovate/flux
renovate flux manager
renovate/helm
renovate helm datasource
type/minor
a minor update
labels
Dec 22, 2023
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
--- kubernetes/talos-flux/apps/kube-tools/node-feature-discovery/app Kustomization: flux-system/apps-node-feature-discovery HelmRelease: kube-tools/node-feature-discovery
+++ kubernetes/talos-flux/apps/kube-tools/node-feature-discovery/app Kustomization: flux-system/apps-node-feature-discovery HelmRelease: kube-tools/node-feature-discovery
@@ -9,13 +9,13 @@
spec:
chart: node-feature-discovery
sourceRef:
kind: HelmRepository
name: node-feature-discovery-charts
namespace: flux-system
- version: 0.14.3
+ version: 0.15.0
install:
createNamespace: true
remediation:
retries: 3
interval: 15m
maxHistory: 15 |
--- kubernetes HelmRelease: kube-tools/node-feature-discovery Deployment: kube-tools/node-feature-discovery-master
+++ kubernetes HelmRelease: kube-tools/node-feature-discovery Deployment: kube-tools/node-feature-discovery-master
@@ -32,26 +32,22 @@
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.14.3
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.15.0
imagePullPolicy: IfNotPresent
livenessProbe:
- exec:
- command:
- - /usr/bin/grpc_health_probe
- - -addr=:8080
+ grpc:
+ port: 8080
initialDelaySeconds: 10
periodSeconds: 10
readinessProbe:
- exec:
- command:
- - /usr/bin/grpc_health_probe
- - -addr=:8080
+ grpc:
+ port: 8080
initialDelaySeconds: 5
periodSeconds: 10
failureThreshold: 10
ports:
- containerPort: 8080
name: grpc
@@ -63,13 +59,12 @@
fieldRef:
fieldPath: spec.nodeName
command:
- nfd-master
resources: {}
args:
- - -port=8080
- -crd-controller=true
- -metrics=8081
volumeMounts:
- name: nfd-master-conf
mountPath: /etc/kubernetes/node-feature-discovery
readOnly: true
--- kubernetes HelmRelease: kube-tools/node-feature-discovery Service: kube-tools/node-feature-discovery-master
+++ kubernetes HelmRelease: kube-tools/node-feature-discovery Service: kube-tools/node-feature-discovery-master
@@ -1,23 +0,0 @@
----
-apiVersion: v1
-kind: Service
-metadata:
- name: node-feature-discovery-master
- namespace: kube-tools
- labels:
- app.kubernetes.io/name: node-feature-discovery
- app.kubernetes.io/instance: node-feature-discovery
- app.kubernetes.io/managed-by: Helm
- role: master
-spec:
- type: ClusterIP
- ports:
- - port: 8080
- targetPort: grpc
- protocol: TCP
- name: grpc
- selector:
- app.kubernetes.io/name: node-feature-discovery
- app.kubernetes.io/instance: node-feature-discovery
- role: master
-
--- kubernetes HelmRelease: kube-tools/node-feature-discovery DaemonSet: kube-tools/node-feature-discovery-worker
+++ kubernetes HelmRelease: kube-tools/node-feature-discovery DaemonSet: kube-tools/node-feature-discovery-worker
@@ -33,24 +33,31 @@
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.14.3
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.15.0
imagePullPolicy: IfNotPresent
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
+ - name: POD_NAME
+ valueFrom:
+ fieldRef:
+ fieldPath: metadata.name
+ - name: POD_UID
+ valueFrom:
+ fieldRef:
+ fieldPath: metadata.uid
resources: {}
command:
- nfd-worker
args:
- - -server=node-feature-discovery-master:8080
- -metrics=8081
ports:
- name: metrics
containerPort: 8081
volumeMounts:
- name: host-boot
--- kubernetes HelmRelease: kube-tools/node-feature-discovery Deployment: kube-tools/node-feature-discovery-gc
+++ kubernetes HelmRelease: kube-tools/node-feature-discovery Deployment: kube-tools/node-feature-discovery-gc
@@ -25,13 +25,13 @@
spec:
serviceAccountName: node-feature-discovery-gc
dnsPolicy: ClusterFirstWithHostNet
securityContext: {}
containers:
- name: gc
- image: registry.k8s.io/nfd/node-feature-discovery:v0.14.3
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.15.0
imagePullPolicy: IfNotPresent
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
@@ -44,7 +44,10 @@
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
+ ports:
+ - name: metrics
+ containerPort: 8081
|
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by OX Security |
tyriis-automation
bot
deleted the
renovate/node-feature-discovery-0.x
branch
December 22, 2023 10:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/kubernetes
cluster/talos-flux
renovate/flux
renovate flux manager
renovate/helm
renovate helm datasource
type/minor
a minor update
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.14.3
->0.15.0
Release Notes
kubernetes-sigs/node-feature-discovery (node-feature-discovery)
v0.15.0
Compare Source
What's new
NodeFeatureRule API extended
Annotations
NFD now supports creating node annotations with the NodeFeatureRuless. See the documentation for details.
matchName
New
matchName
field was added to the NodeFeatureRule CRD. It can be used to match the names of features (instead of their values which is done with thematchExpressions
field). Seedocumentation for details.
Feature files
Hidden feature files: feature files whose name start with a dot (
.
) are now ignored by nfd-worker. This makes it easier to update the feature files by creating a temporary file in the same directory. (#1353)Skip labels or features: Feature files support
# +no-label
and# +no-feature
directives to skip label and feature generation, respectively. See the documentation for details and examples.Container image based on scratch
NFD switched to use scratch as the base container image and to build fully statically linked binaries. Switching to the virtually empty base image means that the default container image only supports running hooks that are also fully statically linked. For example, many go binaries that are "almost" statically linked don't work. The full image variant can be used for richer hook support. NOTE: hooks are deprecated and support for them will be removed in a future release.
Base image of the full image variant was updated to Debian Bookworm.
Discover virtual network interfaces
NFD now discovers virtual network interfaces as features that can be used in NodeFeatureRules. (#1448)
Kubectl plugin
Starting as a developer preview, we are introducing a kubectl-nfd plugin to perform 3 operations against NodeFeatureRule files. (#1446)
See the documentation for more information.
Deprecations
Automatic prefixing of names deprecated
Automatic prefixing of names (of labels, annotations or extended resources) is deprecated. Unprefixed names should not be used in NodeFeatureRules, feature files, hooks or custom rules. The default
feature.node.kubernetes.io/
prefix should be added to unprefixed names.The nfd-master has new
autoDefaultNs
configuration file option (defaults totrue
in v0.15) to stop automatically adding thefeature.node.kubernetes.io/
prefix to node labels, annotations and extended resources. If set tofalse
, unprefixed names will be denied. (#1461)NOTE: The
autoDefaultNs
option default will be changed tofalse
in a future NFD release. This will be a breaking change for users who rely on automatic prefixing of unprefixed names. Setting theautoDefaultNs
option tofalse
with NFD v0.15 can be used to test that all NodeFeatureRules, feature files, hooks and custom rules (configuration of the "custom" feature source of nfd-worker) work correctly when the default will be switched tofalse
.Deprecated security labels dropped
Deprecated
feature.node.kubernetes.io/cpu-sgx.enabled
andfeature.node.kubernetes.io/cpu-se.enabled
labels were dropped. They are replaced byfeature.node.kubernetes.io/cpu-security.sgx.enabled
andfeature.node.kubernetes.io/cpu-security.se.enabled
. (#1350)Legacy "matchOn" custom rule format dropped
Support for the legacy "matchOn" rule format of the custom source of nfd-worker was removed (deprecated since v0.10.0). (#1397)
Miscellaneous
CPU features
Detection of Intel APX and AVX10 as new CPUID features.
New
cpu.topology
featuresocket_count
.Liveness probe
gRPC health probe utility replaced with Kubernetes' built-in gRPC liveness probe. This means that the Kubernetes v1.23 or later is required by the default deployments. (#1046)
Annotations
The nfd-master doesn't create NFD version node annotations anymore. (#1394)
Metrics
Metrics for nfd-gc were added. (#1407)
Example grafana dashboard to display NFD metrics was added. (#1413)
Helm chart
Various fixes and improvments in the Helm chart, for example ability to disable/enable nfd-master and nfd-worker.
NodeFeature API
The nfd-worker now sets owner reference in NodeFeature objects it creates, so orphaned NodeFeatures are automatically garbage-collected when the nfd-worker pod goes away. (#1491)
List of PRs
cpu.topology
(#1497)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.