Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(speedtest-exporter): update to app-template v2.3.0 #2214

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

tyriis
Copy link
Owner

@tyriis tyriis commented Dec 8, 2023

No description provided.

@tyriis-automation
Copy link
Contributor

tyriis-automation bot commented Dec 8, 2023

--- kubernetes/talos-flux/apps/observability/speedtest-exporter/app Kustomization: flux-system/apps-speedtest-exporter HelmRelease: observability/speedtest-exporter

+++ kubernetes/talos-flux/apps/observability/speedtest-exporter/app Kustomization: flux-system/apps-speedtest-exporter HelmRelease: observability/speedtest-exporter

@@ -13,26 +13,37 @@

       chart: app-template
       interval: 15m
       sourceRef:
         kind: HelmRepository
         name: bjw-s-charts
         namespace: flux-system
-      version: 1.5.1
+      version: 2.3.0
   interval: 15m
   values:
-    env:
-      TZ: ${SETTING_TZ}
-    image:
-      repository: ghcr.io/miguelndecarvalho/speedtest-exporter
-      tag: v3.5.4
-    resources:
-      limits:
-        memory: 64M
-      requests:
-        cpu: 15m
-        memory: 64M
+    controllers:
+      main:
+        annotations:
+          reloader.stakater.com/auto: 'true'
+        containers:
+          main:
+            env:
+              TZ: ${SETTING_TZ}
+            image:
+              repository: ghcr.io/miguelndecarvalho/speedtest-exporter
+              tag: v3.5.4
+            nameOverride: speedtest-exporter
+            ports:
+            - containerPort: 9798
+              name: metrics
+              protocol: TCP
+            resources:
+              limits:
+                memory: 64M
+              requests:
+                cpu: 15m
+                memory: 64M
     service:
       main:
         ports:
           http:
             enabled: false
           metrics:

@tyriis-automation
Copy link
Contributor

tyriis-automation bot commented Dec 8, 2023

--- kubernetes HelmRelease: observability/speedtest-exporter Deployment: observability/speedtest-exporter

+++ kubernetes HelmRelease: observability/speedtest-exporter Deployment: observability/speedtest-exporter

@@ -1,67 +1,74 @@

 ---
 apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: speedtest-exporter
   labels:
+    app.kubernetes.io/component: main
     app.kubernetes.io/instance: speedtest-exporter
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: speedtest-exporter
+  annotations:
+    reloader.stakater.com/auto: 'true'
 spec:
   revisionHistoryLimit: 3
   replicas: 1
   strategy:
     type: Recreate
   selector:
     matchLabels:
+      app.kubernetes.io/component: main
       app.kubernetes.io/name: speedtest-exporter
       app.kubernetes.io/instance: speedtest-exporter
   template:
     metadata:
       labels:
+        app.kubernetes.io/component: main
+        app.kubernetes.io/instance: speedtest-exporter
         app.kubernetes.io/name: speedtest-exporter
-        app.kubernetes.io/instance: speedtest-exporter
     spec:
+      enableServiceLinks: true
       serviceAccountName: default
       automountServiceAccountToken: true
+      hostIPC: false
+      hostNetwork: false
+      hostPID: false
       dnsPolicy: ClusterFirst
-      enableServiceLinks: true
       containers:
-      - name: speedtest-exporter
-        image: ghcr.io/miguelndecarvalho/speedtest-exporter:v3.5.4
-        imagePullPolicy: null
-        env:
+      - env:
         - name: TZ
           value: ${SETTING_TZ}
-        ports:
-        - name: metrics
-          containerPort: 9798
-          protocol: TCP
+        image: ghcr.io/miguelndecarvalho/speedtest-exporter:v3.5.4
         livenessProbe:
           failureThreshold: 3
           initialDelaySeconds: 0
           periodSeconds: 10
           tcpSocket:
             port: 9798
           timeoutSeconds: 1
+        name: speedtest-exporter
+        ports:
+        - containerPort: 9798
+          name: metrics
+          protocol: TCP
         readinessProbe:
           failureThreshold: 3
           initialDelaySeconds: 0
           periodSeconds: 10
-          tcpSocket:
-            port: 9798
-          timeoutSeconds: 1
-        startupProbe:
-          failureThreshold: 30
-          initialDelaySeconds: 0
-          periodSeconds: 5
           tcpSocket:
             port: 9798
           timeoutSeconds: 1
         resources:
           limits:
             memory: 64M
           requests:
             cpu: 15m
             memory: 64M
+        startupProbe:
+          failureThreshold: 30
+          initialDelaySeconds: 0
+          periodSeconds: 5
+          tcpSocket:
+            port: 9798
+          timeoutSeconds: 1
 
--- kubernetes HelmRelease: observability/speedtest-exporter Service: observability/speedtest-exporter

+++ kubernetes HelmRelease: observability/speedtest-exporter Service: observability/speedtest-exporter

@@ -1,21 +1,22 @@

 ---
 apiVersion: v1
 kind: Service
 metadata:
   name: speedtest-exporter
   labels:
-    app.kubernetes.io/service: speedtest-exporter
     app.kubernetes.io/instance: speedtest-exporter
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: speedtest-exporter
+    app.kubernetes.io/service: speedtest-exporter
 spec:
   type: ClusterIP
   ports:
   - port: 9798
-    targetPort: metrics
+    targetPort: 9798
     protocol: TCP
     name: metrics
   selector:
+    app.kubernetes.io/component: main
     app.kubernetes.io/instance: speedtest-exporter
     app.kubernetes.io/name: speedtest-exporter
 

@tyriis-automation
Copy link
Contributor

tyriis-automation bot commented Dec 8, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 1.63s
✅ YAML prettier 1 0 0.42s
✅ YAML yamllint 1 0 0.23s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@tyriis tyriis merged commit f067f8b into main Dec 8, 2023
8 checks passed
@tyriis tyriis deleted the feature/app-template-v2-migration branch December 8, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant