Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings for npm/blob-util #434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twaldecker
Copy link
Contributor

Typings URL: https://github.com/twaldecker/typings-blob-util

Questions (for new typings):

  • Does the README explain the purpose and a link to the typed source?
  • Do the typings follow the source structure?
  • Are they correctly external or global modules?

@blakeembrey
Copy link
Member

blakeembrey commented May 22, 2016

@twaldecker Did you test the definition? I think this will be an issue: https://github.com/twaldecker/typings-blob-util/blob/master/index.d.ts#L2. You have an interface but no type for type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants