Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove needless CallableArrayType and CallableStringType #30

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Remove needless CallableArrayType and CallableStringType #30

merged 1 commit into from
Feb 16, 2024

Conversation

klimick
Copy link
Member

@klimick klimick commented Feb 14, 2024

Since this can be expressed through:

  • String callable: callable&string
  • Static array method: callable&list{class-string, string}
  • Instance array method: callable&list{object, string}

Does it make sense to add factory methods for callable-string and callable-array to the types ?
These are quite rare types and the chance that someone will ever use these methods is small.

@vudaltsov vudaltsov merged commit 62e5cd7 into typhoon-php:0.3.x Feb 16, 2024
6 of 7 checks passed
vudaltsov pushed a commit that referenced this pull request Feb 16, 2024
To achive a green pipeline for #30
vudaltsov added a commit to typhoon-php/reflection that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants