-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make rss great again #148
make rss great again #148
Conversation
I am a user of rss feed aggregators and find the current rss feed not as useful as it could be. You can checkout the current state by looking at typelevel.org/blog/feed.rss on feedbucket.com. The list of blog posts is limited to 10 entries and the descriptions are very terse. The terseness, I think, is a bug with the `{% if post.excerpt %}` line. At some point Jekyll decided to auto-generate excerpts if one is not given in the YAML header. So I think this `if` statement is always true. I greped the posts directory and found no use of the `excerpt` variable so I made the decision to just remove the use of the variable in the feed.rss file. The end result is a useful rss feed. It can be previewed at feedbucket.com using this link https://gist.githubusercontent.com/jarrodwb/003ea9995134bde814e6d3545529e483/raw/bbc5d244c734f55fce77dc5b08fc8140be32abea/rss-fixes.rss. The formatting is beautiful on feedbin.com. This is the aggregator I use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to emit full feeds with full content. I use them myself, and appreciate when full content is provided, so I can read directly in my aggregator.
However, if we are to emit full content, it should be more faithful to the original post. For example, code blocks should be syntax-highlighted, and Mathjax blocks should be processed into...something more useful than $R \equiv_m Q$
. Else, it would be better to excerpt and direct via link to a faithful version (i.e. the original page).
It should also include relevant copyright and license information on each article. This isn't so important when excerpting, but an RSS user like me (and I bet @jarrodwb) will rarely see the original site again.
Hi. :-) Thanks for the review. The notes on syntax highlighting and MathJax support are the responsibility of the RSS reader. Feedbin for instance provides syntax highlighting and code blocks for the new RSS feed where as FeedBucket does not. MathJax is similar but I am not sure if Feedbin supports it. Which article contains MathJax? I will take look and see if Feedbin does the right thing. I agree on the the other note on copyright. I can put the same notice as is on http://typelevel.org/about.html which states all content is under CCA3.0 unless otherwise noted. We should also definitely add the author. I missed that. Cheers. :-) |
I am not sure if I have the best solution to the license issue but I put the CC BY 3.0 license into the RSS feed for the whole channel. It is up to the RSS readers/aggregators to display this. I also added the license to each post by changing the post layout. This does not show up in the page content variable so it is not propagated to the RSS items description. I want to do something like this I think what I provided in my last commit is sufficient but is not as nice as I would like. |
I used an CDATA tag to fix the problem I mentioned before. Now all items in the RSS feed have a license at the end of the article. |
Hi @jarrodwb, thanks for the update to incorporate copyright+license information; looks nice.
I don't think this is true, especially when we can render something more likely to succeed for users. (By contrast, we can't do anything about a reader ignoring
Would you mind sharing a screenshot of Feedbin's rendering of, say, the code block beginning with
One example is "Symbolic operators and type classes for Cats": We call an operation ⊕ associative, if for all a, b and c, a⊕(b⊕c)=(a⊕b)⊕c holds. |
I took some screenshots. It looks like even Feedbin does not automatically render MathJax. :-/ I don't have any ideas about how to render the posts before they hit the RSS feed. Maybe we can use what we have and improve on it later. If the rendering is a real blocker for this PR than maybe we can cherry pick some of my changes and abandon the idea of having complete posts shared through the RSS feed. Another option is to open some issues and simply close this PR. https://drive.google.com/open?id=0B1ygQn_r10X_Z2tSNE5NbWw5T3M |
It also does not handle syntax highlighting correctly. Note how everything after the It's worth spinning up two issues for these: #149, #150. Maybe @larsrh has some opinions on the rest. |
I'm happy to merge this as it stands. As far as I can tell it is a strict improvement over the status quo. Is that right? |
Is there any chance of getting a verdict on this? I would like to cross it off my todo list. :-) |
Sorry, I missed that @S11001001 updated his review. Merging now. @jarrodwb, thanks for the contribution! |
I am a user of rss feed aggregators and find the current rss feed not as
useful as it could be. You can checkout the current state by looking at
http://typelevel.org/blog/feed.rss on feedbucket.com. The list of blog posts is
limited to 10 entries and the descriptions are very terse.
The terseness, I think, is a bug with the
{% if post.excerpt %}
line.At some point Jekyll decided to auto-generate excerpts if one is not
given in the YAML header. So I think this
if
statement is always true.I greped the posts directory and found no use of the
excerpt
variableso I made the decision to just remove the use of the variable in the
feed.rss file.
The end result is a useful rss feed. It can be previewed at
feedbucket.com using this link
https://gist.githubusercontent.com/jarrodwb/003ea9995134bde814e6d3545529e483/raw/bbc5d244c734f55fce77dc5b08fc8140be32abea/rss-fixes.rss.
The formatting is beautiful on feedbin.com. This is the aggregator I use.