Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Trigger builds on changes in setup-go/action.yml #4098

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

KapJI
Copy link
Contributor

@KapJI KapJI commented Nov 19, 2024

My goal in this PR was figure out why Windows builds are slow (~90s) on the latest image (20241125.1.0) of github runners when they were much faster (~10s) on previous image version. Unfortunately, I haven't found a solution.

  1. It's not that cache was created on one image and being used on different one.
  2. In new image Go is used from tool cache of runner (RUNNER_TOOL_CACHE) but there is no easy way to always download it. So I was unable to verify if something is wrong with version in the tool cache.

@KapJI KapJI force-pushed the windows-image branch 10 times, most recently from 6bee848 to 3a1d0a5 Compare November 20, 2024 18:24
@KapJI KapJI force-pushed the windows-image branch 2 times, most recently from 98be728 to 5593c61 Compare November 29, 2024 18:44
@KapJI KapJI changed the title chore: Add Windows image version to cache key chore: Trigger builds on changes in setup-go/action.yml Nov 29, 2024
@KapJI KapJI marked this pull request as ready for review November 29, 2024 18:48
@twpayne twpayne merged commit 381551d into twpayne:master Nov 30, 2024
30 checks passed
@twpayne
Copy link
Owner

twpayne commented Nov 30, 2024

Thank you for all your work here. Sometimes computers are frustrating. This PR still makes chezmoi's CI more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants