Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Linuxbrew -> Homebrew #3184

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

osalbahr
Copy link
Contributor

[Homebrew on Linux was formerly referred to as Linuxbrew](https://docs.brew.sh/Homebrew-on-Linux). The two projects got merged.
@halostatue
Copy link
Collaborator

The change here looks fine, but it looks a little weird to have two headings Homebrew. I’ll leave it up to @twpayne to make the decision, but I think that we should do one of two things:

  • remove Homebrew from the macOS section
  • rename this section from Homebrew to Homebrew on Linux

My personal preference is for the latter, but it’s a weak preference.

@osalbahr
Copy link
Contributor Author

I lean more towards keeping it as just Homebrew for brevity reasons and being consistent with having two Nix headings. I’m not sure about, say, “Nix on non-NixOS” either.

I’d like to note that I can see my PR comment being a little misleading. To clarify, “Homebrew on Linux” isn’t the name of a separate package manager that works across Linux systems. It is the same package manager, Homebrew, works on both macOS and Linux. Rather, that phrase is just the heading of a technical documentation webpage.

@bradenhilton
Copy link
Collaborator

I'm of the opinion that Homebrew should be moved from the macOS section to the cross-platform section.

I'd personally also swap the sections so the cross-platform section comes before the platform-specific section, but I feel that may be more contentious.

@halostatue
Copy link
Collaborator

I just looked at the way it shows up on the web page, and this is a special mkdocs format which creates tabs and nested tabs. I think that this is fine as it is for the current structure, because it corrects the project name from Linuxbrew to Homebrew, and it does nothing else.

@halostatue halostatue merged commit 166feaf into twpayne:master Aug 19, 2023
19 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants