Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional twirp prefix #264

Merged
merged 19 commits into from
Sep 13, 2020
Merged

Optional twirp prefix #264

merged 19 commits into from
Sep 13, 2020

Commits on Aug 24, 2020

  1. docs website cleanup .gitignore and add package-lock.json in case the… 

    … docs are generated with npm instead of yarn
    @marioizquierdo
    marioizquierdo committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    b5095f7 View commit details
    Browse the repository at this point in the history

  2. Client option WithClientPathPrefix allows to specify a different path… 

    … prefix, keeping /twirp as default.
    @marioizquierdo
    marioizquierdo committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    a646a49 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Update client option to twirp.SkipPathPrefix(), which fits the curren… 

    …t path schema easier
    @marioizquierdo
    marioizquierdo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    85aca69 View commit details
    Browse the repository at this point in the history

  2. Generate code and test cients with the new option (using the default … 

    …value)
    @marioizquierdo
    marioizquierdo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    cf5e1bd View commit details
    Browse the repository at this point in the history

  3. review comments

    @marioizquierdo
    marioizquierdo committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    afc0c81 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Route requests by path suffix, which allows to mount services on arbi… 

    …trary prefixes
    @marioizquierdo
    marioizquierdo committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    5d9d1c9 View commit details
    Browse the repository at this point in the history

  2. Add tests for services and clients using different path prefixes

    @marioizquierdo
    marioizquierdo committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    f8cb685 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Client option twirp.WithClientPathPrefix(prefix), where /twirp is the… 

    … default prefix
    @marioizquierdo
    marioizquierdo committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    fc1a41a View commit details
    Browse the repository at this point in the history

  2. Add server options when initializing with the constructor. Add twirp.… 

    …WithServerPathPrefix option to specify a different routing option
    @marioizquierdo
    marioizquierdo committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    78fc2b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. server.PathPrefix() returns the service base path with the specified … 

    …path prefix
    @marioizquierdo
    marioizquierdo committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    f35701c View commit details
    Browse the repository at this point in the history

  2. Add a few more tests to verify the server.PathPrefix() keeps the same… 

    … value by default
    @marioizquierdo
    marioizquierdo committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    a1b7fe5 View commit details
    Browse the repository at this point in the history

  3. Review instructions to use cURL

    @marioizquierdo
    marioizquierdo committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    0cbc965 View commit details
    Browse the repository at this point in the history

  4. Review docs, update routing and spec to specify a flexible path prefix

    @marioizquierdo
    marioizquierdo committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    8a90385 View commit details
    Browse the repository at this point in the history

  5. Make the documentation link in the README easier to find

    @marioizquierdo
    marioizquierdo committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    89eddb7 View commit details
    Browse the repository at this point in the history

  6. Generate docs

    @marioizquierdo
    marioizquierdo committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    8c5b366 View commit details
    Browse the repository at this point in the history

  7. Review and updates on docs/routing.md

    @marioizquierdo
    marioizquierdo committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    6541a0c View commit details
    Browse the repository at this point in the history

  8. More edits to simplify routing docs

    @marioizquierdo
    marioizquierdo committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    7484d9c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. Routing changes are part of protocol v7

    @marioizquierdo
    marioizquierdo committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    dc6772d View commit details
    Browse the repository at this point in the history

  2. keep v5 as current and v7 as Draft until v7 is officially released

    @marioizquierdo
    marioizquierdo committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    ec1e7bb View commit details
    Browse the repository at this point in the history