Clean up object record filter #9550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbordeau
force-pushed
the
refactor/object-filter-states-3
branch
from
885ffd7 to
f0074a2
Compare
charlesBochet
approved these changes
Jan 10, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the object filter dropdown state management across the application, moving from a scope-based context approach to direct Recoil component state management.
- Removed
ObjectFilterDropdownScopecomponent and associated hooks (useFilterDropdown,useFilterDropdownStates,useSetFilterDefinitionUsedInDropdownInScope) in favor of directObjectFilterDropdownComponentInstanceContext.Provider - Replaced
useRecoilValuewithuseRecoilComponentValueV2for more granular state management across filter components - Migrated filter state management from centralized hooks to individual component-level Recoil states
- Standardized state access patterns by using component-specific state atoms instead of shared hooks
- Simplified component hierarchy by removing redundant context providers while maintaining functionality
35 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
39
to
40
| <AdvancedFilterViewFilterFieldSelect viewFilterId={filter.id} /> | ||
| <AdvancedFilterViewFilterOperandSelect viewFilterId={filter.id} /> |
There was a problem hiding this comment.
logic: using filter.id here but viewFilterId was passed as prop - ensure these IDs are always equivalent
There was a problem hiding this comment.
logic: Deleting core state management code. Make sure there are replacement mechanisms in place for all these filter states to maintain functionality.
| newFilter.id, | ||
| filterDefinition, | ||
| ); | ||
| selectFilterDefinitionUsedInDropdown({ filterDefinition }); |
There was a problem hiding this comment.
logic: selectFilterDefinitionUsedInDropdown is called before checking if it succeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last clean up of object dropdown filter states v1.
Removed old state scope context component.