Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix regression on multiItem input field when no item #9543

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

etiennejouan
Copy link
Contributor

@etiennejouan etiennejouan commented Jan 10, 2025

Context

Fix on 8904 issue (PR) introduces a regression when field has no item.
Background should be lighter.
Screenshot 2025-01-10 at 16 08 03

Solution

Conditional styling, displayed only when MultiInput has item
Screenshot 2025-01-10 at 16 08 20

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed styling regression in multi-item input fields by implementing conditional background styling and consistent height across input components.

  • Added hasItem prop to StyledCustomPhoneInputContainer to only show background styling when items are present
  • Adjusted PhoneCountryPickerDropdownButton height from 30px to 32px for consistency with other inputs
  • Added conditional styling in MultiItemBaseInput to only apply background/border when items exist
  • Unified styling behavior across phone, email and domain name input fields

💡 (5/5) You can turn off certain types of comments like style here!

4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@guillim guillim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etiennejouan etiennejouan force-pushed the etienne/fix/field-input-design branch from 05e13ed to 9bb172c Compare January 10, 2025 15:45
@etiennejouan etiennejouan enabled auto-merge (squash) January 10, 2025 17:16
@etiennejouan etiennejouan disabled auto-merge January 10, 2025 17:17
@charlesBochet charlesBochet merged commit 11a4726 into main Jan 10, 2025
21 of 23 checks passed
@charlesBochet charlesBochet deleted the etienne/fix/field-input-design branch January 10, 2025 17:32
Copy link

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-60db998f.json

Generated by 🚫 dangerJS against cc02ff2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔦 In QA
Development

Successfully merging this pull request may close these issues.

4 participants