feat(auth, settings): allow to impersonate on mono workspace mode #9451
+38
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for multi-workspace checks during impersonation and streamlined token verification flows. Adjusted session clearing and navigation logic to improve user transition between workspaces.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced impersonation functionality to support both single and multi-workspace environments, with improved session management and authentication flows.
- Added
clearSessioncall before redirecting in single-workspace impersonation inuseImpersonate.ts - Simplified
VerifyEffectcomponent by removinggetTokens()wrapper and flattening verification logic - Moved
setIsVerifyPendingStatemanagement intohandleVerifyinuseAuth.tsfor better state control - Added
isMultiWorkspaceEnabledchecks in impersonation flow to handle workspace-specific redirections - Streamlined token verification by removing unnecessary data returns from auth handler functions
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+36
to
+39
| if (isDefined(loginToken)) { | ||
| setIsAppWaitingForFreshObjectMetadata(true); | ||
| verify(loginToken); | ||
| } else if (!isLogged) { |
There was a problem hiding this comment.
logic: verify() returns a Promise but is not being awaited - this could cause race conditions if the verification fails
packages/twenty-front/src/modules/settings/admin-panel/hooks/useImpersonate.ts
Outdated
Show resolved
Hide resolved
| @@ -268,6 +268,8 @@ export const useAuth = () => { | |||
|
|
|||
| const handleVerify = useCallback( | |||
| async (loginToken: string) => { | |||
| setIsVerifyPendingState(true); | |||
There was a problem hiding this comment.
logic: setIsVerifyPendingState(true) should be wrapped in try/catch to ensure it gets set back to false if verification fails
…nation flow Simplified test assertions in `useAuth.test.tsx` by removing redundant property checks from the signup method. Enhanced `useImpersonate` hook by refactoring workspace condition logic and introducing fresh metadata states to improve session handling.
|
@ehconitin feel free to close it when you cherry-picked the commits |
|
Thanks @AMoreaux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for multi-workspace checks during impersonation and streamlined token verification flows. Adjusted session clearing and navigation logic to improve user transition between workspaces.