Remove identifierFieldMetadataId from createObjectInput #9450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Removes labelIdentifierFieldMetadataId and imageIdentifierFieldMetadataId fields from CreateObjectInput to prevent invalid references during object creation, as these fields only make sense after the object exists.
- Removed
labelIdentifierFieldMetadataIdandimageIdentifierFieldMetadataIdfrompackages/twenty-server/src/engine/metadata-modules/object-metadata/dtos/create-object.input.ts - Removed unused
IsUUIDimport from class-validator - Fields remain available in
UpdateObjectInputwhere they are logically needed
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing labelIdentifierFieldMetadataId and imageIdentifierFieldMetadataId that should not be part of createObjectInput as they don't make sense for an object yet to create and will break