Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow dark mode improvements #9412

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

Devessier
Copy link
Contributor

Dark mode

Old vs New

CleanShot 2025-01-06 at 17 49 19@2x

CleanShot 2025-01-06 at 17 49 32@2x

Light mode

Old vs New

CleanShot 2025-01-06 at 17 49 11@2x

CleanShot 2025-01-06 at 17 49 01@2x

@Devessier Devessier marked this pull request as ready for review January 6, 2025 16:50
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances dark mode support in the workflow diagram components by replacing hardcoded colors with theme-aware alternatives for better visual consistency across color schemes.

  • Updated WorkflowDiagramCanvasBase.tsx to use theme-aware border color instead of hardcoded GRAY_SCALE.gray25
  • Modified WorkflowDiagramBaseStepNode.tsx node type text color to use theme.font.color.light
  • Changed selected node background in WorkflowDiagramBaseStepNode.tsx to theme.accent.quaternary
  • Improved visual contrast in dark mode while maintaining light mode appearance

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosiraphael bosiraphael merged commit c61831c into main Jan 6, 2025
23 checks passed
@bosiraphael bosiraphael deleted the workflow-dark-mode-improvements branch January 6, 2025 17:07
Copy link

github-actions bot commented Jan 6, 2025

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-efe7903a.json

Generated by 🚫 dangerJS against cdeb3d7

@HeyGarrison
Copy link

This looks amazing - great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants