feat(sso): add support for identityProviderId in SAML flow #9411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated SAML callback URLs and relevant logic to include identityProviderId, ensuring better handling of multiple identity providers. Refactored client and server-side code to streamline form interactions and validation within the SSO module.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances SSO identity provider handling, particularly focusing on SAML flow improvements and direct provider access support.
- Added identityProviderId to SAML callback URLs and metadata generation in
sso-auth.controller.tsto support direct SSO access from providers - Fixed form validation in
SettingsSSOSAMLForm.tsxby triggering validation after file upload to resolve greyed-out Save button - Optimized form state management in
SettingsSSOIdentitiesProvidersForm.tsxusinguseMemoandwatchinstead ofgetValues - Updated URL path construction in
sso.service.tsto include provider ID for consistent multi-provider support - Streamlined form submission in
SettingsSecuritySSOIdentifyProvider.tsxusinglodash.pickfor targeted field selection
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+38
to
+45
| await createSSOIdentityProvider( | ||
| SSOIdentitiesProvidersParamsSchema.parse( | ||
| pick( | ||
| formConfig.getValues(), | ||
| Object.keys(sSOIdentityProviderDefaultValues[type]()), | ||
| ), | ||
| ), | ||
| ); |
There was a problem hiding this comment.
logic: This validation approach could allow invalid fields to be submitted if they were populated before switching SSO types. Consider clearing irrelevant fields when type changes.
FelixMalfait
approved these changes
Jan 7, 2025
Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated SAML callback URLs and relevant logic to include identityProviderId, ensuring better handling of multiple identity providers. Refactored client and server-side code to streamline form interactions and validation within the SSO module.
Fix #9323 #9325