Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix: missing key prop in RecordShowActionMenuButtons component #9184

Conversation

harshrajeevsingh
Copy link
Contributor

Screenshot from 2024-12-21 20-03-55

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR addresses a React warning by adding a missing key prop to the IconButton component within the RecordShowActionMenuButtons component.

  • Using array index as key in packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenuButtons.tsx could cause rendering issues if entries are reordered
  • Optional chaining on entry.onClick?.() should be replaced with a proper default or error handling
  • Consider adding loading/error states for the useRecoilComponentValueV2 selector

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@harshrajeevsingh harshrajeevsingh deleted the fix/minor-key-missing-RecordShowActionMenuButtons branch December 23, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant