Remove favorite folder related feature flags #9178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR removes feature flag controls for favorite folders functionality across the frontend and backend, making it a permanent feature rather than conditionally enabled.
- Removed
IS_FAVORITE_FOLDER_ENABLEDandIS_FAVORITE_FOLDER_ENTITY_ENABLEDfrompackages/twenty-front/src/modules/workspace/types/FeatureFlagKey.tsand corresponding server enums - Merged
PrefetchFavoriteFoldersRunQueriesEffectintopackages/twenty-front/src/modules/prefetch/components/PrefetchRunQueriesEffect.tsxto consolidate prefetching logic - Removed feature flag gates from workspace entities in
packages/twenty-server/src/modules/favorite-folder/standard-objects/favorite-folder.workspace-entity.tsand related files - Simplified loading states in
packages/twenty-front/src/modules/prefetch/hooks/useIsPrefetchLoading.tsto always include favorite folders prefetching - Removed feature flag seeds from
packages/twenty-server/src/database/typeorm-seeds/core/feature-flags.tssince the functionality is now permanent
16 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/prefetch/hooks/useIsPrefetchLoading.ts
Show resolved
Hide resolved
packages/twenty-server/src/database/typeorm-seeds/core/feature-flags.ts
Outdated
Show resolved
Hide resolved
|
Thanks @ehconitin for your contribution! |
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this pull request
Dec 28, 2024
Co-authored-by: Weiko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.