Make record name editable on show page #9172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds record name editing functionality in the show page header and breadcrumb navigation, with conditional rendering based on field visibility.
- Added new
RecordEditableNamecomponent in/pages/object-record/RecordEditableName.tsxfor inline name editing with proper loading states - Modified
RecordShowPageHeaderto conditionally render editable name whenlayout.hideSummaryAndFieldsis true - Made
Iconprop optional inNavigationDrawerInputandNavigationDrawerItemcomponents to support breadcrumb editing - Added Storybook story with GraphQL mocks to test
RecordEditableNamerendering and interactions - Exposed
objectMetadataItemthroughuseRecordShowPagePaginationhook to support metadata access for name editing
8 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/pages/object-record/__stories__/RecordEditableName.stories.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/object-record/RecordEditableName.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/object-record/RecordEditableName.tsx
Outdated
Show resolved
Hide resolved
thomtrp
force-pushed
the
tt-make-record-name-editable-in-breadcumb
branch
2 times, most recently
from
7c19f5e to
9a5a87e
Compare
thomtrp
force-pushed
the
tt-make-record-name-editable-in-breadcumb
branch
from
b2c2e2e to
d470edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fields are not displayed in show page, title should be editable
Enregistrement.de.l.ecran.2024-12-20.a.16.04.24.mov