-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command menu actions fixes #9169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bosiraphael
commented
Dec 20, 2024
- Fix command menu not closing after executing an action
- Add delete and favorite actions to workflow and workflow versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR enhances the command menu functionality and adds workflow management features, focusing on action execution and menu behavior.
- Added
wrapActionInCallbacks.ts
to properly handle action execution lifecycle with before/after callbacks - Modified
ActionMenuContext.ts
to support both sync and async callbacks for better action handling - Added workflow actions in
WorkflowSingleRecordActionsConfig.ts
for managing favorites, deletion, and version control - Fixed import path casing across files from 'singleRecordActionHook' to 'SingleRecordActionHook' for consistency
- Enhanced
ActionHookResult
type to support async actions and improved confirmation modal typing
29 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
...action-menu/actions/record-actions/multiple-records/hooks/useExportMultipleRecordsAction.tsx
Outdated
Show resolved
Hide resolved
.../record-actions/single-record/components/ShowPageSingleRecordActionMenuEntrySetterEffect.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/actions/utils/wrapActionInCallbacks.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/actions/utils/wrapActionInCallbacks.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/actions/utils/wrapActionInCallbacks.ts
Show resolved
Hide resolved
...action-menu/actions/record-actions/multiple-records/hooks/useExportMultipleRecordsAction.tsx
Show resolved
Hide resolved
.../record-actions/single-record/components/ShowPageSingleRecordActionMenuEntrySetterEffect.tsx
Show resolved
Hide resolved
charlesBochet
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.