Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command menu actions fixes #9169

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Command menu actions fixes #9169

merged 9 commits into from
Dec 20, 2024

Conversation

bosiraphael
Copy link
Contributor

  • Fix command menu not closing after executing an action
  • Add delete and favorite actions to workflow and workflow versions

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the command menu functionality and adds workflow management features, focusing on action execution and menu behavior.

  • Added wrapActionInCallbacks.ts to properly handle action execution lifecycle with before/after callbacks
  • Modified ActionMenuContext.ts to support both sync and async callbacks for better action handling
  • Added workflow actions in WorkflowSingleRecordActionsConfig.ts for managing favorites, deletion, and version control
  • Fixed import path casing across files from 'singleRecordActionHook' to 'SingleRecordActionHook' for consistency
  • Enhanced ActionHookResult type to support async actions and improved confirmation modal typing

29 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile

@bosiraphael bosiraphael enabled auto-merge (squash) December 20, 2024 13:38
@bosiraphael bosiraphael merged commit d08075f into main Dec 20, 2024
22 checks passed
@bosiraphael bosiraphael deleted the r-workflow-actions-fixes branch December 20, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants