Add possibility to destroy a record #9144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added functionality to permanently destroy records through a new action menu option, complementing the existing soft-delete feature with a permanent deletion capability.
- Added
useDestroySingleRecordActionhook in/packages/twenty-front/src/modules/action-menu/actions/record-actions/single-record/hooks/useDestroySingleRecordAction.tsxfor permanent record deletion - Added
destroySingleRecordaction configuration inDefaultSingleRecordActionsConfigV2.tswith danger styling and IconTrashX - Modified
useDeleteSingleRecordActionto prevent deletion of already deleted records viadeletedAtcheck - Added
IconTrashXtoTablerIcons.tsfor visual distinction between soft and permanent deletion
4 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
...on-menu/actions/record-actions/single-record/constants/DefaultSingleRecordActionsConfigV2.ts
Show resolved
Hide resolved
Comment on lines
+40
to
+41
| const shouldBeRegistered = | ||
| !isRemoteObject && isDefined(selectedRecord?.deletedAt); |
There was a problem hiding this comment.
logic: Logic appears reversed - shouldBeRegistered checks for deletedAt being defined, which means it only allows destroying already-deleted records. Should likely be !isDefined(selectedRecord?.deletedAt) to allow destroying non-deleted records.
...ules/action-menu/actions/record-actions/single-record/hooks/useDestroySingleRecordAction.tsx
Show resolved
Hide resolved
Comment on lines
62
to
68
| onConfirmClick={() => { | ||
| handleDeleteClick(); | ||
| onActionExecutedCallback?.(); | ||
| if (isInRightDrawer) { | ||
| closeRightDrawer(); | ||
| } | ||
| }} |
There was a problem hiding this comment.
style: Modal's onConfirmClick should handle async operation properly. Currently calls callbacks before destroy completes.
bosiraphael
reviewed
Dec 19, 2024
mdrazak2001
pushed a commit
to mdrazak2001/twenty
that referenced
this pull request
Dec 20, 2024
There are two follow ups to this PR: - Bug: sometimes when opening Cmd+K from a deleted record, we are facing a global error - On Index page, actions in top right are displaying label and not short name - Implement multiple actions once refactoring on delete is complete --------- Co-authored-by: bosiraphael <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two follow ups to this PR: