Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue of scroll paddings in Navigation Drawer #9138

Closed
wants to merge 1 commit into from

Conversation

muraliSingh7
Copy link
Contributor

This PR fixes the issue #9026

Screenshot:
image
image

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes scroll padding issues in the Navigation Drawer by ensuring proper scrollbar visibility and preventing overlap with navigation items.

  • Removed scrollHide={true} from ScrollWrapper in packages/twenty-front/src/modules/navigation/components/MainNavigationDrawerItems.tsx to show scrollbar
  • Added theme-based spacing and width calculations in packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerItem.tsx for better layout
  • Implemented margin-right in packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerSectionTitle.tsx to prevent scrollbar overlap
  • Improved text overflow handling with ellipsis in navigation items
  • Optimized spacer component rendering to appear only when needed

💡 (4/5) You can add custom instructions or style guidelines for the bot here!

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@ehconitin
Copy link
Contributor

Thanks, @muraliSingh7, this is not the correct approach. Here we are changing the NavigationDrawerItems width i.e. 204px according to Figma designs.
Thanks for the effort, I will be fixing it in #9141
Closing this PR ;)

@ehconitin ehconitin closed this Dec 19, 2024
@muraliSingh7
Copy link
Contributor Author

@ehconitin Thank you for your feedback. I acknowledge that my approach didn't align with the design specifications, and I appreciate your clarification. However, I followed the current pattern established by the core maintainers, where fixed values for width are used. If there's a preference to avoid such fixed values, I would have appreciated a more collaborative discussion on how we can improve this approach going forward.

I believe it would be more productive to ask whether we can explore alternatives rather than closing the PR immediately. It's important to recognize the effort that contributors put in, and fostering a supportive dialogue can lead to better outcomes for everyone.

@ehconitin
Copy link
Contributor

@muraliSingh7
Thank you for the PR. While I did ask you to create it to test the behavior, the implementation needs to follow specific requirements that were talked about internally. We are experimenting with different scroll behavior and padding configurations.

Given these constraints and internal priorities, I'll implement this in #9141. I should have told you more about these requirements when you offered to help.

Please understand that maintainers' decisions are based on project requirements rather than personal preferences.

There are many issues to be picked, sorry for this one ;)

Thanks for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants