Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workspace gates for aggregate fields metadata #9125

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ijreilly
Copy link
Collaborator

As part of our rollout strategy, let's remove the workspaces gates, which will trigger the creation of the field metadatas needed for the aggregate queries features.
In a later release we will remove the feature flag completely, after all fields have been created for all workspaces

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Removes workspace gate decorators for aggregate fields in view entities to prepare for enabling aggregate query features across all workspaces.

  • Removed @WorkspaceGate decorator from kanbanAggregateOperation and kanbanAggregateOperationFieldMetadataId in /packages/twenty-server/src/modules/view/standard-objects/view.workspace-entity.ts
  • Removed @WorkspaceGate decorator from aggregateOperation field in /packages/twenty-server/src/modules/view/standard-objects/view-field.workspace-entity.ts
  • Removed unused FeatureFlagKey import from both files

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Weiko Weiko merged commit f482b45 into main Dec 18, 2024
22 checks passed
@Weiko Weiko deleted the remove-aggregate-fields-gates branch December 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants