Add some tests to the variable resolver to ensure static JSON is properly evaluated #9104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added test coverage for JSON string handling in the variable resolver utility, focusing on variable interpolation and static JSON preservation.
- Added test case in
/packages/twenty-server/src/modules/workflow/workflow-executor/utils/__tests__/variable-resolver.util.spec.tsto verify JSON property names with variables - Added test case to ensure static JSON strings remain unmodified
- Added test cases for variable interpolation in JSON number and string values
- Added test to verify variables in JSON strings don't get wrapped with double quotes
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+78
to
+84
| it('does not wrap string variables with double quotes', () => { | ||
| expect( | ||
| resolveInput('{ {{test}}: 2 }', { | ||
| test: 'prop', | ||
| }), | ||
| ).toBe('{ prop: 2 }'); | ||
| }); |
There was a problem hiding this comment.
style: The whitespace in the expected string '{ prop: 2 }' may be implementation-dependent. Consider testing the parsed JSON object instead of the string representation.
thomtrp
approved these changes
Dec 17, 2024
|
Thanks @Devessier for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.