Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composite field creation #9044

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix composite field creation #9044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .../workflow/workflow-executor/workflow-actions/record-crud/create-record.workflow-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,10 @@ export class CreateRecordWorkflowAction implements WorkflowAction {
workflowActionInput.objectName,
);

const objectRecord = await repository.create(
const objectRecord = await repository.save(
workflowActionInput.objectRecord,
);
Comment on lines +20 to 22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Directly calling save() bypasses entity validation that create() provides. Consider wrapping in try/catch to handle validation errors gracefully.


await repository.save(objectRecord);

return {
result: objectRecord,
};
Expand Down
Loading