Fast follows on 0.34

[charlesBochet]

No description provided.

[greptile-apps]

PR Summary

This PR refactors frontend URL configuration by splitting FRONT_BASE_URL into three separate environment variables (FRONT_DOMAIN, FRONT_PORT, FRONT_PROTOCOL) across Docker, K8s, and server configurations.

• Introduces granular frontend URL control in /packages/twenty-docker/.env.example with new variables FRONT_DOMAIN, FRONT_PORT, and FRONT_PROTOCOL
• Updates K8s manifests in /packages/twenty-docker/k8s/manifests/ to use split URL variables for both server and worker deployments
• Adds new front_domain variable in /packages/twenty-docker/k8s/terraform/variables.tf that overlaps with existing twentycrm_app_hostname
• Updates upgrade guide in /packages/twenty-website/src/content/developers/self-hosting/upgrade-guide.mdx with inconsistent section headers vs content
• Removes FRONT_BASE_URL from test configurations in /packages/twenty-server/.env.test

_{10 file(s) reviewed, 11 comment(s)
Edit PR Review Bot Settings | Greptile}

[AMoreaux]

The PORT of the SERVER_URL should differ from the frontend.

We should allow to set the FRONT_PORT without the FRONT_PROTOCOL and FRONT_DOMAIN.

Like that:

Suggested change

	getFrontUrl() {
	let baseUrl: URL;
	if (!this.environmentService.get('FRONT_DOMAIN')) {
	baseUrl = new URL(this.environmentService.get('SERVER_URL'));
	} else {
	baseUrl = new URL(
	`${this.environmentService.get('FRONT_PROTOCOL')}://${this.environmentService.get('FRONT_DOMAIN')}`,
	);
	const port = this.environmentService.get('FRONT_PORT');
	if (port) {
	baseUrl.port = port.toString();
	}
	}
	return baseUrl;
	}
	getFrontUrl() {
	let baseUrl: URL;
	if (!this.environmentService.get('FRONT_DOMAIN')) {
	baseUrl = new URL(this.environmentService.get('SERVER_URL'));
	} else {
	baseUrl = new URL(
	`${this.environmentService.get('FRONT_PROTOCOL')}://${this.environmentService.get('FRONT_DOMAIN')}`,
	);
	}
	const port = this.environmentService.get('FRONT_PORT');
	if (port) {
	baseUrl.port = port.toString();
	}
	return baseUrl;
	}

[charlesBochet]

Our main concern is to lower the number of env variables needed

• in self hosting main case: we want front to be served on same url as server and we only have to specify SERVER_URL
• in local development case: we only have to specify FRONT_DOMAIN and FRONT_PORT in .env

Actually, I don't disagree with you, we could change port and protocol in separate if conditions and achieve the same goal

@Weiko what do you think?

[DillonMercz]

good enough