[Fix] isLabelSyncedWithName should be nullable #9028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Makes the isLabelSyncedWithName field nullable in both server-side DTOs and generated GraphQL types to fix inconsistencies in field optionality.
- Modified
@Fielddecorator in/packages/twenty-server/src/engine/metadata-modules/field-metadata/dtos/field-metadata.dto.tsto include{ nullable: true } - Updated generated types in
/packages/twenty-front/src/generated-metadata/graphql.tsto reflect nullable boolean field - Change aligns with existing
@IsOptional()decorator and TypeScript optional modifier
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
ijreilly
commented
Dec 11, 2024
| @@ -147,7 +147,7 @@ export class FieldMetadataDTO< | |||
|
|
|||
| @IsBoolean() | |||
| @IsOptional() | |||
| @Field() | |||
| @Field({ nullable: true }) | |||
There was a problem hiding this comment.
this is nullable in the input but non-null in db, as it is for objectMetadata. I really need to double check but I think we want to allow null values in the input that we backfill in the service
Weiko
approved these changes
Dec 12, 2024
| const response = await makeMetadataAPIRequest(graphqlOperation); | ||
|
|
||
| // Assert | ||
| console.log( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isLabelSyncedWithName should be nullable for fieldMetadata, as it is for objectMetadata.