8726 workflow add a test button in workflow code step #9016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code-step Remove useless backend call
martmull
force-pushed
the
8726-workflow-add-a-test-button-in-workflow-code-step
branch
from
57f83a7 to
f12418a
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds test functionality to workflow code steps, including a test button and test tab interface for executing and viewing serverless function results.
- Added new
ServerlessFunctionExecutionResultcomponent in/packages/twenty-front/src/modules/serverless-functions/components/to display test execution status, duration, and output - Implemented
useTestServerlessFunctionhook in/packages/twenty-front/src/modules/serverless-functions/hooks/for managing test execution state and handling responses - Removed
CodeIntrospectionServiceand related files in favor of simpler schema handling withBASE_TYPESCRIPT_PROJECT_INPUT_SCHEMA - Added comprehensive test coverage for serverless function utilities in
/packages/twenty-front/src/modules/serverless-functions/utils/__tests__/ - Refactored tab state management across components to use
useTabListhook directly instead of Recoil state
77 file(s) reviewed, 59 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/action-menu/components/CmdEnterActionButton.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/components/CmdEnterActionButton.tsx
Show resolved
Hide resolved
...wenty-front/src/modules/object-record/record-field/form-types/hooks/useTextVariableEditor.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/serverless-functions/constants/IndexFilePath.ts
Show resolved
Hide resolved
...enty-front/src/modules/serverless-functions/components/ServerlessFunctionExecutionResult.tsx
Show resolved
Hide resolved
packages/twenty-server/src/modules/workflow/workflow-builder/types/output-schema.type.ts
Show resolved
Hide resolved
martmull
force-pushed
the
8726-workflow-add-a-test-button-in-workflow-code-step
branch
from
0ca4ed8 to
4136651
Compare
martmull
force-pushed
the
8726-workflow-add-a-test-button-in-workflow-code-step
branch
from
9ac1ed5 to
3d0c160
Compare
thomtrp
reviewed
Dec 11, 2024
...wenty-front/src/modules/serverless-functions/utils/getDefaultFunctionInputFromInputSchema.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSubContainer.tsx
Outdated
Show resolved
Hide resolved
...ules/workflow/workflow-actions/components/WorkflowEditActionFormServerlessFunctionFields.tsx
Outdated
Show resolved
Hide resolved
Devessier
reviewed
Dec 11, 2024
...wenty-front/src/modules/object-record/record-field/form-types/hooks/useTextVariableEditor.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/serverless-functions/constants/IndexFilePath.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/serverless-functions/hooks/useTestServerlessFunction.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/serverless-functions/hooks/useTestServerlessFunction.ts
Outdated
Show resolved
Hide resolved
...wenty-front/src/modules/serverless-functions/utils/getDefaultFunctionInputFromInputSchema.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/serverless-functions/utils/getFunctionInputFromSourceCode.ts
Outdated
Show resolved
Hide resolved
...ront/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormDeleteRecord.tsx
Show resolved
Hide resolved
thomtrp
reviewed
Dec 12, 2024
packages/twenty-front/src/modules/serverless-functions/hooks/useTestServerlessFunction.ts
Show resolved
Hide resolved
.../modules/settings/serverless-functions/components/tabs/SettingsServerlessFunctionTestTab.tsx
Outdated
Show resolved
Hide resolved
...y-front/src/modules/workflow/workflow-actions/components/WorkflowEditActionFormSendEmail.tsx
Show resolved
Hide resolved
...ules/workflow/workflow-actions/components/WorkflowEditActionFormServerlessFunctionFields.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/modules/workflow/workflow-builder/types/output-schema.type.ts
Outdated
Show resolved
Hide resolved
Devessier
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Great work! Thank you!
As discussed, removing the "Test" button from the "Code" would be great. I think it doesn't provide the best UX as the code and the test parts are separate, making it hard to know the arguments used when launching a test from the "Code" tab.
...rc/modules/workflow/workflow-actions/components/WorkflowEditActionFormServerlessFunction.tsx
Outdated
Show resolved
Hide resolved
...rc/modules/workflow/workflow-actions/components/WorkflowEditActionFormServerlessFunction.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/right-drawer/components/RightDrawerFooter.tsx
Outdated
Show resolved
Hide resolved
...rc/modules/workflow/workflow-actions/components/WorkflowEditActionFormServerlessFunction.tsx
Outdated
Show resolved
Hide resolved
...rc/modules/workflow/workflow-actions/components/WorkflowEditActionFormServerlessFunction.tsx
Outdated
Show resolved
Hide resolved
...rc/modules/workflow/workflow-actions/components/WorkflowEditActionFormServerlessFunction.tsx
Outdated
Show resolved
Hide resolved
martmull
force-pushed
the
8726-workflow-add-a-test-button-in-workflow-code-step
branch
from
8794909 to
96103f0
Compare
martmull
force-pushed
the
8726-workflow-add-a-test-button-in-workflow-code-step
branch
from
96103f0 to
1c19366
Compare
martmull
force-pushed
the
8726-workflow-add-a-test-button-in-workflow-code-step
branch
from
3ab11cb to
2a938f1
Compare
martmull
deleted the
8726-workflow-add-a-test-button-in-workflow-code-step
branch
charlesBochet
pushed a commit
that referenced
this pull request
Dec 18, 2024
- Fixed icon shrinking on tabs. The introduction of EllipsisDisplay takes 100% of the width, thus shrinking the icons. - Removed scroll wrapper tablist. This was removed in #9016 but reintroduced in #9089. This reintroduction made the dark border below the active tab disappear. - Used Avatar for icon and logo rendering following the changes made in #9093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enregistrement.de.l.ecran.2024-12-11.a.15.09.10.mov