Block google signinup on wrong subdomain #9015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements security measures to prevent unauthorized Google SSO authentication by validating workspace subdomains and displaying relevant error messages to users.
- Added new
ErrorToastProviderin/packages/twenty-front/src/modules/error-handler/components/ErrorToastProvider.tsxto display authentication errors from URL parameters - Modified
/packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.tsto block sign-ups on non-default subdomains when multi-workspace is enabled - Extracted and made public
hasAccessToWorkspacemethod in/packages/twenty-server/src/engine/core-modules/auth/services/auth.service.tsfor reusable workspace access validation - Simplified
/packages/twenty-server/src/engine/core-modules/auth/controllers/google-auth.controller.tsby removing redundant workspace checks and delegating to AuthService
5 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/error-handler/components/ErrorToastProvider.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/error-handler/components/ErrorToastProvider.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts
Show resolved
Hide resolved
Comment on lines
+178
to
+187
| if ( | ||
| this.environmentService.get('IS_MULTIWORKSPACE_ENABLED') && | ||
| targetWorkspaceSubdomain !== | ||
| this.environmentService.get('DEFAULT_SUBDOMAIN') | ||
| ) { | ||
| throw new AuthException( | ||
| 'You are not allowed to sign up on this domain', | ||
| AuthExceptionCode.FORBIDDEN_EXCEPTION, | ||
| ); | ||
| } |
There was a problem hiding this comment.
logic: this check prevents sign-ups on non-default subdomains but should also verify the user doesn't have an existing account on any workspace before blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.