fix: recordBoard sticky header + scrollThumb #8946
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes UI issues with the RecordBoard component's header and scrollbar by adjusting container dimensions and layout properties.
- Modified
StyledContainerWithPaddingwidth calculation in/packages/twenty-front/src/modules/object-record/record-index/components/RecordIndexContainer.tsxto properly account for left margin spacing - Removed
height: 100%fromStyledContainerContainerin/packages/twenty-front/src/modules/object-record/record-board/components/RecordBoard.tsxto fix sticky header behavior - Added
height: calc(100% - 48px)toStyledBoardContentContainerto ensure proper scrollable area
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...ages/twenty-front/src/modules/object-record/record-index/components/RecordIndexContainer.tsx
Outdated
Show resolved
Hide resolved
| margin-left: ${({ theme }) => theme.spacing(2)}; | ||
| width: 100%; | ||
| width: calc(100% - ${({ theme }) => theme.spacing(2)}); |
There was a problem hiding this comment.
Could we use box-sizing: border-box instead of calculating width?
There was a problem hiding this comment.
I tried! It didn't work ;(
There was a problem hiding this comment.
@ehconitin could you try taking over this change?
| @@ -17,7 +17,7 @@ import 'overlayscrollbars/overlayscrollbars.css'; | |||
|
|
|||
| const StyledScrollWrapper = styled.div<{ scrollHide?: boolean }>` | |||
| display: flex; | |||
| height: fit-content; | |||
There was a problem hiding this comment.
This change introduced in #9062 broke the scroll on the recordboard, reverted!
There was a problem hiding this comment.
LGTM!
@harshrajeevsingh Great work, Thanks!
box-sizing: border-box; does work instead of calculating width :)
I am not sure why it didn't work on your side, could you please re-verify if the reason of it not working is linux specific?
|
Thanks @harshrajeevsingh for your contribution! |
It's working not because of |
Fixes: #8944
Screencast.from.2024-12-08.00-43-19.webm