-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: last field overflow #8510
base: main
Are you sure you want to change the base?
fix: last field overflow #8510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Fixed overflow issue in table cells by removing min-width property from StyledEditableCellEditModeContainer, allowing input fields to shift left instead of extending beyond screen boundaries.
- Modified
packages/twenty-front/src/modules/object-record/record-table/record-table-cell/components/RecordTableCellEditMode.tsx
to remove min-width constraint - Potential concern: remaining
min-width: 200px
in StyledTableCellInput could still cause overflow issues
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
@harshrajeevsingh This issue should be fixed by using the overflow detection mechanism from the library we use for dropdowns : floating-ui. The trick is to tell the dropdown to watch for overflow against the main app container. Try this : flip({
boundary: document.querySelector('#root') ?? undefined
}), In |
Hey, @lucasbordeau Thanks for the input. I'm already familiar with this package since I solved many related issues earlier in this repo. I tried the code you provided above, but it didn't work. I think the issue is indeed happening due to the width of the Removing the excessive width larger than the inline cell makes the detection overflow work and the element is positioned based on the available viewport. Also, removing it won't cause any problem since Screencast.from.2024-11-16.00-05-49.webm |
@lucasbordeau let's not forget this one :) |
Fixes: #7216
The issue was caused by the
min-width
property ofStyledEditableCellEditModeContainer
. So, I removed it.