-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete unused objects #7823
Delete unused objects #7823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @FelixMalfait ! I think sync-metadata won't work there because we are removing multiple objects that depend on each others and we don't have a clear control on the order of deletion.
Also we might need a command for people that created custom relations between their objects and those deleted tables 🤔. We could do like we do with deprecated fields and instead of deleting those objects (and tables), we convert them to custom objects, that would be the "easy" solution but definitely not the best there I think
Edit: we could also update the sync-metatadata logic so it properly removes the foreign key constraints before deleting objects
I've updated your PR.
|
Fixes #7113