Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sentry fix] handle undefined createdBy case #7818

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[sentry fix] handle undefined createdBy case #7818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ages/twenty-server/src/engine/core-modules/actor/query-hooks/created-by.pre-query-hook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export class CreatedByPreQueryHook implements WorkspaceQueryHookInstance {

for (const datum of payload.data) {
// Front-end can fill the source field
if (createdBy && (!datum.createdBy || !datum.createdBy.name)) {
if (createdBy && (!datum.createdBy || !datum.createdBy?.name)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a redundant check here, wdyt?
Could be

if (createdBy && (!datum.createdBy?.name))

datum.createdBy = {
...createdBy,
source: datum.createdBy?.source ?? createdBy.source,
Expand Down
Loading