fix : 7223 Clicking Outside Fields domain link email phone Close Them #7804
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses an issue where clicking outside certain fields (domain, links, email, phone) did not close them as expected. The main change focuses on improving the click-outside behavior in the MultiItemFieldInput component.
- Added
handleDropdownCloseOutsidefunction inMultiItemFieldInput.tsxto handle click-outside events - Modified
useListenClickOutsidehook usage to incorporate the new click-outside handler - Implemented
event.stopImmediatePropagation()to prevent unintended event bubbling - Ensured consistency with standard behavior of other fields for improved user experience
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| const handleDropdownCloseOutside = (event: MouseEvent | TouchEvent) => { | ||
| onCancel?.(); | ||
| event.stopImmediatePropagation(); | ||
| }; |
There was a problem hiding this comment.
style: Consider adding a check if onCancel exists before calling it
| useListenClickOutside({ | ||
| refs: [containerRef], | ||
| callback: handleDropdownClose, | ||
| callback: handleDropdownCloseOutside, | ||
| }); | ||
|
|
||
| useScopedHotkeys(Key.Escape, handleDropdownClose, hotkeyScope); |
There was a problem hiding this comment.
style: Consider moving this line after the state declarations for better organization
|
@Bonapara could you please review this request?? |
|
LGTM from a product point of view! Thanks @prathameshpatil5181. Over to the tech team for their review. |
|
/award 100 |
|
Awarding prathameshpatil5181: 100 points 🕹️ Well done! Check out your new contribution on oss.gg/prathameshpatil5181 |
|
@charlesBochet @Bonapara I'll review it as this behavior can be tricky and can easily cause regression. |
fixes #7223
https://github.com/user-attachments/assets/1150e96f-4fb5-40ba-ac17-89d8b2ab16e7