Adjust the line height and expand the maximum height of the plac… #7764
Conversation
…eholder subtitle text.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adjusts the styling of the placeholder subtitle text in the EmptyPlaceholderStyled component to address the issue of cut-off letters in the Functions section.
- Increased line height from 'md' to 'lg' in
StyledEmptySubTitlecomponent - Expanded max-height from 2.4em to 2.8em in
StyledEmptySubTitlecomponent - These changes aim to resolve the text truncation issue in the Functions placeholder
- The modifications affect the
/packages/twenty-front/src/modules/ui/layout/animated-placeholder/components/EmptyPlaceholderStyled.tsxfile - Users can verify the fix by checking the Functions section in the Advanced settings
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| line-height: ${({ theme }) => theme.text.lineHeight.md}; | ||
| max-height: 2.4em; | ||
| line-height: ${({ theme }) => theme.text.lineHeight.lg}; | ||
| max-height: 2.8em; |
There was a problem hiding this comment.
style: Consider using a more flexible approach, such as max-height: calc(2 * ${({ theme }) => theme.text.lineHeight.lg}); to ensure consistency with the theme's line height.
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
Can you make the row gap between the title and description 8px instead of 12px? (Increasing the line height enlarges the spacing between lines.) |
Yes, I have adjusted the row gap between the title and description to 8px |
|
Awarding abdullah5361k: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/abdullah5361k |
fixes: #7757
What does this PR do?
We increased the line height from md to lg and the max height of the placeholder subtitle text from 2.4 to 2.8 to ensure that letters are no longer slightly cut off in the placeholder in Functions.
How should this be tested?