Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7665 handle the select all case inside the action menu #7742

Merged

Conversation

bosiraphael
Copy link
Contributor

Closes #7665

  • Handle select all
  • Handle Filters

@bosiraphael bosiraphael linked an issue Oct 16, 2024 that may be closed by this pull request
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR implements the 'select all' functionality in the action menu and modifies the context store structure to accommodate this change. Key updates include:

  • Introduced new contextStoreTargetedRecordsState with selectedRecords and excludedRecords properties
  • Added useContextStoreSelectedRecords hook to handle the new state structure
  • Updated RecordActionMenuEntriesSetter to use the new hook for record selection
  • Modified DeleteRecordsActionEffect, ExportRecordsActionEffect, and ManageFavoritesActionEffect to work with the new state
  • Renamed turnObjectDropdownFilterIntoQueryFilter to turnFiltersIntoQueryFilter and updated its implementation
  • Refactored useRecordData (formerly useTableData) to handle the new context store structure
  • Updated RecordIndexContainer and related components to use the new ActionMenu component

30 file(s) reviewed, 29 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bosiraphael tried locally with more records and delete does not work as expected (only findMany on the first page and does not trigger a delete), I'll let you check!

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bosiraphael bosiraphael merged commit 40152d3 into main Oct 21, 2024
20 checks passed
@bosiraphael bosiraphael deleted the 7665-handle-the-select-all-case-inside-the-action-menu branch October 21, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle the select all case inside the action menu
4 participants