-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Nav Item Api & Webhook and Functions stay selected #7628
Fix: Nav Item Api & Webhook and Functions stay selected #7628
Conversation
…vigating the data model settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request modifies the SettingsNavigationDrawerItems component to fix the selection behavior of 'API & Webhooks' and 'Functions' navigation items in the settings menu.
- Added
matchSubPages
prop to 'API & Webhooks' and 'Functions' items inpackages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx
- Ensures these items remain selected when navigating to sub-pages, similar to data model settings
- Addresses issue Settings Nav item doesn't stay selected #7573 where 'API & Webhooks' menu item lost selection when accessing webhook pages
- Improves user experience by maintaining consistent navigation state across settings sub-sections
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @tushar110302 Thank you for contributing!
Happy to contribute and become a part of it 🙂 |
Thanks @tushar110302! |
…em-does-not-stay-selected
packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx
Show resolved
Hide resolved
Awarding tushar110302: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/tushar110302 |
@FelixMalfait :) follow up - #7628
Fixed Nav Item Api & Webhook and Functions stay selected like data model settings.
Now when clicked stays selected and deos not loose its selection
Fixes #7573
Screen.Recording.2024-10-13.at.9.43.25.AM.mp4