[Fix] - Issue with Email Validation and API Call Trigger on Login #7510 #7596
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request enhances email validation in the SignInUpForm component, improving user experience and data integrity during the sign-in/up process.
- Implemented strict email format validation in
packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpForm.tsx - Added logic to disable the "Continue" button until email validation is complete
- Introduced error message display for invalid email formats
- Improved user feedback by preventing submission of invalid email addresses
- Enhanced the overall sign-in/up flow by ensuring valid email input before proceeding
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| if (form?.formState?.errors?.email) { | ||
| setShowErrors(true); | ||
| return; | ||
| } |
There was a problem hiding this comment.
style: Consider moving this validation logic to the continueWithCredentials function for better separation of concerns.
|
Hi @Karankhatik, thanks for your PR. We would like the validation check to occur only when the "Continue" button is pressed, rather than while the user is typing. We don't want to show an error message if the user hasn't completed their input. |
| @@ -76,6 +76,10 @@ export const SignInUpForm = () => { | |||
| if (signInUpStep === SignInUpStep.Init) { | |||
| continueWithEmail(); | |||
| } else if (signInUpStep === SignInUpStep.Email) { | |||
| if (isDefined(form?.formState?.errors?.email)) { | |||
There was a problem hiding this comment.
using isDefined is better to avoid unwanted falsy behaviors
There was a problem hiding this comment.
Thank you @Karankhatik. I have made a small modification :)
|
Thanks @Karankhatik for your contribution! |
Purpose: Enhance email validation in the SignInUpForm component.
Changes: