7338 refactor actionbar and contextmenu to use the context store #7462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se-the-context-store
…se-the-context-store
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request refactors the ActionBar and ContextMenu components to use a new context store, improving state management and component organization.
- Introduced new context store states for managing object metadata, view IDs, and targeted record IDs
- Replaced separate action bar and context menu states with a unified action menu state
- Added new ActionMenuEffect, ActionBar, and ActionMenuDropdown components for centralized action menu management
- Removed RecordBoardActionBar and RecordBoardContextMenu components, consolidating functionality into new action menu components
- Updated RecordBoard and RecordBoardCard components to use the new action menu system and context store
30 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings
packages/twenty-front/src/effect-components/PageChangeEffect.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/components/ActionBar.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/components/ActionMenuDropdown.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/components/ActionMenuEffect.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/components/ActionMenuNavigationModal.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/action-menu/right-drawer/components/RightDrawerActionMenu.tsx
Outdated
Show resolved
Hide resolved
…ext-store' of github.com:twentyhq/twenty into 7338-refactor-actionbar-and-contextmenu-to-use-the-context-store
…se-the-context-store
...ages/twenty-front/src/modules/object-metadata/states/objectMetadataItemFamilySelectorById.ts
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Oct 9, 2024
charlesBochet
deleted the
7338-refactor-actionbar-and-contextmenu-to-use-the-context-store
branch
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7338