Fix all broken CIs #7439
Merged
Fix all broken CIs #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request focuses on refactoring and improving test files across multiple modules, with a particular emphasis on standardizing test setups and updating GraphQL fragments.
- Introduced
getJestMetadataAndApolloMocksWrapperutility function to simplify and standardize test setups across multiple test files - Updated GraphQL fragments in
personFragments.ts, replacingPERSON_FRAGMENTwith more specificPERSON_FRAGMENT_WITH_DEPTH_ZERO_RELATIONSandPERSON_FRAGMENT_WITH_DEPTH_ONE_RELATIONS - Modified
mapObjectMetadataToGraphQLQueryinpackages/twenty-front/src/modules/object-metadata/utils/mapObjectMetadataToGraphQLQuery.tsto sort fields alphabetically for consistent query generation - Improved object metadata matching in
getRecordNodeFromRecordfunction withinpackages/twenty-front/src/modules/object-record/cache/utils/getRecordNodeFromRecord.ts - Removed unnecessary imports and simplified test structures across multiple test files, improving maintainability and readability
30 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| id | ||
| intro | ||
| jobTitle | ||
| linkedinLink{ |
There was a problem hiding this comment.
syntax: There's an inconsistent space after 'linkedinLink'
| } | ||
| ` | ||
|
|
||
| export const PERSON_FRAGMENT_WITH_DEPTH_ONE_RELATIONS = ` |
There was a problem hiding this comment.
style: This fragment is quite large and may impact query performance. Consider splitting it into smaller, more focused fragments
charlesBochet
force-pushed
the
fix-tests-n
branch
from
b9b0b64 to
454e03c
Compare
charlesBochet
added a commit
that referenced
this pull request
Oct 4, 2024
Fix all the broken CIs :p This includes an ongoing effort to simplify test maintenance by having 1 unique source of truth about metadata and data mocks (that will later be generated from a unique source of seeds: dev = demo = test) Regressions: - Unit line coverage: 60 > 55 - Storybook Pages branch coverage: 40 > 35 We will need to write tests to increase those coverage - RelationFieldDisplay perf: 0.2ms to 0.22ms > We might have a regression here - Removed perf story about RawJSON > We will need to re-add it
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Fix all the broken CIs :p This includes an ongoing effort to simplify test maintenance by having 1 unique source of truth about metadata and data mocks (that will later be generated from a unique source of seeds: dev = demo = test) Regressions: - Unit line coverage: 60 > 55 - Storybook Pages branch coverage: 40 > 35 We will need to write tests to increase those coverage - RelationFieldDisplay perf: 0.2ms to 0.22ms > We might have a regression here - Removed perf story about RawJSON > We will need to re-add it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all the broken CIs :p
This includes an ongoing effort to simplify test maintenance by having 1 unique source of truth about metadata and data mocks (that will later be generated from a unique source of seeds: dev = demo = test)
Regressions:
We will need to write tests to increase those coverage