Fix syncStageStartedAt not correctly set #7436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses an issue with the 'syncStageStartedAt' field not being correctly set during the message import process in the Twenty server.
- Added setting of 'syncStageStartedAt' in
packages/twenty-server/src/modules/messaging/common/services/message-channel-sync-status.service.tswhen marking channels as 'MESSAGES_IMPORT_ONGOING' - Removed MessageChannelSyncStage check and import in
packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts - Removed 'syncStageStartedAt: null' from update operation in
packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-partial-message-list-fetch.service.ts - These changes aim to improve sync stage tracking and process management
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
| @@ -55,13 +52,6 @@ export class MessagingMessagesImportService { | |||
| let messageIdsToFetch: string[] = []; | |||
|
|
|||
| try { | |||
| if ( | |||
There was a problem hiding this comment.
@bosiraphael why are we removing this condition? it seems legit to me
| @@ -54,7 +54,6 @@ export class MessagingPartialMessageListFetchService { | |||
| }, | |||
| { | |||
| throttleFailureCount: 0, | |||
| syncStageStartedAt: null, | |||
There was a problem hiding this comment.
I'm not sure about this one, are you afraid of race conditions?
There was a problem hiding this comment.
actually I agree with this one as this is the role of the message-channel-sync status
| @@ -161,6 +161,7 @@ export class MessageChannelSyncStatusService { | |||
|
|
|||
| await messageChannelRepository.update(messageChannelIds, { | |||
| syncStage: MessageChannelSyncStage.MESSAGES_IMPORT_ONGOING, | |||
| syncStageStartedAt: new Date().toISOString(), | |||
There was a problem hiding this comment.
I think that's it, I'm not sure about the other changes
charlesBochet
approved these changes
Oct 4, 2024
harshit078
pushed a commit
to harshit078/twenty
that referenced
this pull request
Oct 14, 2024
Fix syncStageStartedAt not correctly set --------- Co-authored-by: Charles Bochet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix syncStageStartedAt not correctly set