-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: created by prefill value for demo instance #7383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request updates the 'createdByName' field for sample company and person data in the workspace prefill functionality.
- Modified
packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/company.ts
to change 'createdByName' from 'System' to 'Twenty (Sample data)' for all sample companies - Updated
packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/person.ts
to set 'createdByName' as 'Twenty (Sample data)' for all sample person entries - These changes address issue Update demo data "Created by" values #6924, improving the context and appearance of sample data in new workspaces
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
createdBySource: 'MANUAL', | ||
createdByWorkspaceMemberId: null, | ||
createdByName: 'System', | ||
createdByName: 'Twenty (Sample data)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding a constant for 'Twenty (Sample data)' to maintain consistency and ease future updates
@Bonapara Ready for review |
@Nabhag8848 I believe @FelixMalfait wanted to discuss this one with @Bonapara prio to merging it. |
/award 150 |
Awarding Nabhag8848: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Nabhag8848 |
I'm sorry @Nabhag8848 I didn't see this PR. Someone also raise a PR which I reviewed and ended up doing something else #7424 |
ISSUE