Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: created by prefill value for demo instance #7383

Closed
wants to merge 4 commits into from

Conversation

Nabhag8848
Copy link
Contributor

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request updates the 'createdByName' field for sample company and person data in the workspace prefill functionality.

  • Modified packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/company.ts to change 'createdByName' from 'System' to 'Twenty (Sample data)' for all sample companies
  • Updated packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/person.ts to set 'createdByName' as 'Twenty (Sample data)' for all sample person entries
  • These changes address issue Update demo data "Created by" values #6924, improving the context and appearance of sample data in new workspaces

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

Comment on lines 46 to 48
createdBySource: 'MANUAL',
createdByWorkspaceMemberId: null,
createdByName: 'System',
createdByName: 'Twenty (Sample data)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding a constant for 'Twenty (Sample data)' to maintain consistency and ease future updates

@Nabhag8848
Copy link
Contributor Author

@Bonapara Ready for review

@Nabhag8848 Nabhag8848 changed the title fix: created by value for demo instance fix: created by prefill value for demo instance Oct 2, 2024
@charlesBochet
Copy link
Member

@Nabhag8848 I believe @FelixMalfait wanted to discuss this one with @Bonapara prio to merging it.
It's likely that we want to introduce another creator source instead of only modifying the createdByName

@FelixMalfait
Copy link
Member

/award 150

Copy link

oss-gg bot commented Oct 5, 2024

Awarding Nabhag8848: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Nabhag8848

@FelixMalfait
Copy link
Member

I'm sorry @Nabhag8848 I didn't see this PR. Someone also raise a PR which I reviewed and ended up doing something else #7424
(I ended up keeping System and adding a different icon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update demo data "Created by" values
3 participants