-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade sentry #7145
Upgrade sentry #7145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR upgrades Sentry to version 8 and introduces Sentry Cron monitoring across the application, enhancing error tracking and monitoring capabilities for both frontend and backend components.
- Added
SentryCronMonitor
decorator inpackages/twenty-server/src/engine/core-modules/cron/sentry-cron-monitor.decorator.ts
for monitoring cron jobs - Updated Sentry initialization in
packages/twenty-front/src/modules/error-handler/components/SentryInitEffect.tsx
with new integrations and configurations - Modified
packages/twenty-server/src/engine/core-modules/exception-handler/drivers/sentry.driver.ts
to include Redis integration and adjust sample rates - Applied
SentryCronMonitor
decorator to various cron jobs in calendar and messaging modules - Centralized cron pattern definitions by moving them from command files to their respective job files
19 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
packages/twenty-server/src/engine/core-modules/exception-handler/drivers/sentry.driver.ts
Outdated
Show resolved
Hide resolved
@@ -34,6 +38,7 @@ export class MessagingMessagesImportCronJob { | |||
) {} | |||
|
|||
@Process(MessagingMessagesImportCronJob.name) | |||
@SentryCronMonitor(MessagingMessagesImportCronJob.name, MESSAGING_MESSAGES_IMPORT_CRON_PATTERN) | |||
async handle(): Promise<void> { | |||
console.time('MessagingMessagesImportCronJob time'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider using a logging library instead of console.time for better observability
...les/messaging/monitoring/crons/jobs/messaging-message-channel-sync-status-monitoring.cron.ts
Outdated
Show resolved
Hide resolved
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Upgrave Sentry to v8 and add Sentry Cron monitoring