Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sentry #7145

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Upgrade sentry #7145

merged 6 commits into from
Sep 19, 2024

Conversation

FelixMalfait
Copy link
Member

Upgrave Sentry to v8 and add Sentry Cron monitoring

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR upgrades Sentry to version 8 and introduces Sentry Cron monitoring across the application, enhancing error tracking and monitoring capabilities for both frontend and backend components.

  • Added SentryCronMonitor decorator in packages/twenty-server/src/engine/core-modules/cron/sentry-cron-monitor.decorator.ts for monitoring cron jobs
  • Updated Sentry initialization in packages/twenty-front/src/modules/error-handler/components/SentryInitEffect.tsx with new integrations and configurations
  • Modified packages/twenty-server/src/engine/core-modules/exception-handler/drivers/sentry.driver.ts to include Redis integration and adjust sample rates
  • Applied SentryCronMonitor decorator to various cron jobs in calendar and messaging modules
  • Centralized cron pattern definitions by moving them from command files to their respective job files

19 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings

@@ -34,6 +38,7 @@ export class MessagingMessagesImportCronJob {
) {}

@Process(MessagingMessagesImportCronJob.name)
@SentryCronMonitor(MessagingMessagesImportCronJob.name, MESSAGING_MESSAGES_IMPORT_CRON_PATTERN)
async handle(): Promise<void> {
console.time('MessagingMessagesImportCronJob time');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider using a logging library instead of console.time for better observability

@charlesBochet charlesBochet merged commit 3025ac3 into main Sep 19, 2024
15 of 16 checks passed
@charlesBochet charlesBochet deleted the upgrade-sentry branch September 19, 2024 16:09
Copy link

sentry-io bot commented Sep 20, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'requestHandler') bootstrap(main.ts) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants